Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 100623006: Move dom_distiller_service_factory to //chrome. (Closed)

Created:
7 years ago by blundell
Modified:
7 years ago
Reviewers:
cjhopman, rlarocque, Yaron
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, rsimha+watch_chromium.org, Yaron, noyau (Ping after 24h)
Visibility:
Public.

Description

Move dom_distiller_service_factory to //chrome. Treat the concept of "how to get the DomDistillerService to use for the given browsing context" as an embedder-level concept rather than a concept within the dom_distiller component. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238958

Patch Set 1 #

Patch Set 2 : Add OWNERS file #

Patch Set 3 : Rebase after conflict with blundell@chromium.org (!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -142 lines) Patch
A + chrome/browser/dom_distiller/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/dom_distiller/dom_distiller_service_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/dom_distiller.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D components/dom_distiller/content/dom_distiller_service_factory.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/dom_distiller/content/dom_distiller_service_factory.cc View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
blundell
Chris, most of this file is the result of tools/git/move_source_file.py; then some minor cleanup that ...
7 years ago (2013-12-04 12:56:03 UTC) #1
cjhopman
On 2013/12/04 12:56:03, blundell wrote: > Chris, most of this file is the result of ...
7 years ago (2013-12-04 18:31:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/100623006/20001
7 years ago (2013-12-04 19:36:37 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=39406
7 years ago (2013-12-04 19:54:23 UTC) #4
Yaron
+Richard for sync
7 years ago (2013-12-04 19:59:08 UTC) #5
rlarocque
On 2013/12/04 19:59:08, Yaron wrote: > +Richard for sync LGTM for c/b/sync/profile_sync_components_factory_impl.cc change.
7 years ago (2013-12-04 20:23:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/100623006/20001
7 years ago (2013-12-04 21:02:27 UTC) #7
commit-bot: I haz the power
Failed to apply patch for components/dom_distiller.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-04 21:02:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/100623006/40001
7 years ago (2013-12-05 10:02:43 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-05 12:44:25 UTC) #10
Message was sent while issue was closed.
Change committed as 238958

Powered by Google App Engine
This is Rietveld 408576698