Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: mojo/shell/android/mojo_main.cc

Issue 100623003: Remove separate thread for the shell on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: , Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/native_viewport/native_viewport_android.cc ('k') | mojo/shell/task_runners.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/android/mojo_main.cc
diff --git a/mojo/shell/android/mojo_main.cc b/mojo/shell/android/mojo_main.cc
index 55b1c53cf7bcc6fca8d9b0aa6d87325ded738bae..18dc5f60864e52f70b1fcae237d24a79ed7749ff 100644
--- a/mojo/shell/android/mojo_main.cc
+++ b/mojo/shell/android/mojo_main.cc
@@ -10,7 +10,6 @@
#include "base/command_line.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
-#include "base/threading/thread.h"
#include "jni/MojoMain_jni.h"
#include "mojo/shell/init.h"
#include "mojo/shell/run.h"
@@ -27,28 +26,9 @@ base::AtExitManager* g_at_exit = 0;
LazyInstance<scoped_ptr<base::MessageLoop> > g_java_message_loop =
LAZY_INSTANCE_INITIALIZER;
-LazyInstance<scoped_ptr<base::Thread> > g_shell_thread =
- LAZY_INSTANCE_INITIALIZER;
-
LazyInstance<scoped_ptr<shell::Context> > g_context =
LAZY_INSTANCE_INITIALIZER;
-struct ShellInit {
- scoped_refptr<base::SingleThreadTaskRunner> java_runner;
- base::android::ScopedJavaGlobalRef<jobject> activity;
-};
-
-void StartOnShellThread(ShellInit* init) {
- shell::Context* context = new shell::Context();
-
- context->set_activity(init->activity.obj());
- context->task_runners()->set_java_runner(init->java_runner.get());
- delete init;
-
- g_context.Get().reset(context);
- shell::Run(context);
-}
-
} // namspace
static void Init(JNIEnv* env, jclass clazz, jobject context) {
@@ -83,16 +63,13 @@ static void Start(JNIEnv* env, jclass clazz, jobject context, jstring jurl) {
CommandLine::ForCurrentProcess()->InitFromArgv(argv);
}
- ShellInit* init = new ShellInit();
- init->java_runner = base::MessageLoopForUI::current()->message_loop_proxy();
- init->activity.Reset(env, context);
-
- g_shell_thread.Get().reset(new base::Thread("shell_thread"));
- g_shell_thread.Get()->Start();
- g_shell_thread.Get()->message_loop()->PostTask(FROM_HERE,
- base::Bind(StartOnShellThread, init));
+ base::android::ScopedJavaGlobalRef<jobject> activity;
+ activity.Reset(env, context);
- // TODO(abarth): Currently we leak g_shell_thread.
+ shell::Context* shell_context = new shell::Context();
+ shell_context->set_activity(activity.obj());
+ g_context.Get().reset(shell_context);
+ shell::Run(shell_context);
}
bool RegisterMojoMain(JNIEnv* env) {
« no previous file with comments | « mojo/services/native_viewport/native_viewport_android.cc ('k') | mojo/shell/task_runners.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698