Add error handling to validate expectation names.

Add error handling to validate expectation names.

Do not allow slashes (\ or /), quotes (" or ') or spaces.

BUG=None
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238443

[baxley, 2013-12-03 00:23:04]

This CL raises ValueErrors in methods that call UploadImage, to avoid uploading
"bad" names. Let me know what you think.

[craigdh, 2013-12-03 00:30:50]

https://codereview.chromium.org/100623002/diff/1/chrome/test/functional/ispy/...
File chrome/test/functional/ispy/common/ispy_utils.py (right):

https://codereview.chromium.org/100623002/diff/1/chrome/test/functional/ispy/...
chrome/test/functional/ispy/common/ispy_utils.py:19: def
IsValidExpectationName(expectationName):
return any(c in _INVALID_EXPECTATION_CHARS for c in expectation_name)

https://codereview.chromium.org/100623002/diff/1/chrome/test/functional/ispy/...
chrome/test/functional/ispy/common/ispy_utils.py:19: def
IsValidExpectationName(expectationName):
expectationName -> expectation_name

[baxley, 2013-12-03 00:53:16]

Comments addressed.

https://codereview.chromium.org/100623002/diff/1/chrome/test/functional/ispy/...
File chrome/test/functional/ispy/common/ispy_utils.py (right):

https://codereview.chromium.org/100623002/diff/1/chrome/test/functional/ispy/...
chrome/test/functional/ispy/common/ispy_utils.py:19: def
IsValidExpectationName(expectationName):
On 2013/12/03 00:30:50, craigdh wrote:
> expectationName -> expectation_name

Done.

https://codereview.chromium.org/100623002/diff/1/chrome/test/functional/ispy/...
chrome/test/functional/ispy/common/ispy_utils.py:19: def
IsValidExpectationName(expectationName):
On 2013/12/03 00:30:50, craigdh wrote:
> return any(c in _INVALID_EXPECTATION_CHARS for c in expectation_name)

Done.

[craigdh, 2013-12-03 00:56:08]

lgtm w/ nit

https://codereview.chromium.org/100623002/diff/20001/chrome/test/functional/i...
File chrome/test/functional/ispy/common/ispy_utils.py (right):

https://codereview.chromium.org/100623002/diff/20001/chrome/test/functional/i...
chrome/test/functional/ispy/common/ispy_utils.py:111: raise
ValueError("Expectation contains an illegal value: %s." %
value -> character

[craigdh, 2013-12-03 00:56:49]

please make sure to run the unittests before landing.

[baxley, 2013-12-03 01:07:16]

Nit addressed and unit tests passed. I'll wait until tomorrow to land this.

https://codereview.chromium.org/100623002/diff/20001/chrome/test/functional/i...
File chrome/test/functional/ispy/common/ispy_utils.py (right):

https://codereview.chromium.org/100623002/diff/20001/chrome/test/functional/i...
chrome/test/functional/ispy/common/ispy_utils.py:111: raise
ValueError("Expectation contains an illegal value: %s." %
On 2013/12/03 00:56:08, craigdh wrote:
> value -> character

Nice catch. Done.

[commit-bot: I haz the power, 2013-12-03 19:58:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/baxley@chromium.org/100623002/40001

[commit-bot: I haz the power, 2013-12-03 19:59:59]

Change committed as 238443