Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: net/tools/quic/quic_spdy_client_stream_test.cc

Issue 1006193003: Remove Balsa from QuicSpdyClientStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.cc ('k') | net/tools/quic/quic_spdy_server_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_client_stream_test.cc
diff --git a/net/tools/quic/quic_spdy_client_stream_test.cc b/net/tools/quic/quic_spdy_client_stream_test.cc
index 323018eff6e4b1a88855f855232f0d2e24b28d02..c5032c86ac9dcbc4dc86b48d06e4e61cd998f54b 100644
--- a/net/tools/quic/quic_spdy_client_stream_test.cc
+++ b/net/tools/quic/quic_spdy_client_stream_test.cc
@@ -65,31 +65,32 @@ INSTANTIATE_TEST_CASE_P(Tests, QuicSpdyClientStreamTest,
::testing::ValuesIn(QuicSupportedVersions()));
TEST_P(QuicSpdyClientStreamTest, TestFraming) {
- EXPECT_EQ(headers_string_.size(), stream_->ProcessData(
- headers_string_.c_str(), headers_string_.size()));
- EXPECT_EQ(body_.size(),
- stream_->ProcessData(body_.c_str(), body_.size()));
- EXPECT_EQ(200u, stream_->headers().parsed_response_code());
+ stream_->OnStreamHeaders(headers_string_);
+ stream_->OnStreamHeadersComplete(false, headers_string_.size());
+ EXPECT_EQ(body_.size(), stream_->ProcessData(body_.c_str(), body_.size()));
+ EXPECT_EQ("200 Ok", stream_->headers().find(":status")->second);
+ EXPECT_EQ(200, stream_->response_code());
EXPECT_EQ(body_, stream_->data());
}
TEST_P(QuicSpdyClientStreamTest, TestFramingOnePacket) {
- string message = headers_string_ + body_;
-
- EXPECT_EQ(message.size(), stream_->ProcessData(
- message.c_str(), message.size()));
- EXPECT_EQ(200u, stream_->headers().parsed_response_code());
+ stream_->OnStreamHeaders(headers_string_);
+ stream_->OnStreamHeadersComplete(false, headers_string_.size());
+ EXPECT_EQ(body_.size(), stream_->ProcessData(body_.c_str(), body_.size()));
+ EXPECT_EQ("200 Ok", stream_->headers().find(":status")->second);
+ EXPECT_EQ(200, stream_->response_code());
EXPECT_EQ(body_, stream_->data());
}
TEST_P(QuicSpdyClientStreamTest, DISABLED_TestFramingExtraData) {
string large_body = "hello world!!!!!!";
- EXPECT_EQ(headers_string_.size(), stream_->ProcessData(
- headers_string_.c_str(), headers_string_.size()));
+ stream_->OnStreamHeaders(headers_string_);
+ stream_->OnStreamHeadersComplete(false, headers_string_.size());
// The headers should parse successfully.
EXPECT_EQ(QUIC_STREAM_NO_ERROR, stream_->stream_error());
- EXPECT_EQ(200u, stream_->headers().parsed_response_code());
+ EXPECT_EQ("200 Ok", stream_->headers().find(":status")->second);
+ EXPECT_EQ(200, stream_->response_code());
EXPECT_CALL(*connection_,
SendRstStream(stream_->id(), QUIC_BAD_APPLICATION_PAYLOAD, 0));
« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.cc ('k') | net/tools/quic/quic_spdy_server_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698