Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1006193003: Remove Balsa from QuicSpdyClientStream. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Balsa from QuicSpdyClientStream. To facilitate landing actual QuicServer support in Chromium using Chromium's MessageLoop and friends. Merge internal change: 89526581 Committed: https://crrev.com/40fa174740fe5c16d4e1377bad45791206b8bae7 Cr-Commit-Position: refs/heads/master@{#322246}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -96 lines) Patch
M net/tools/quic/quic_client.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 3 chunks +11 lines, -13 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 2 3 chunks +56 lines, -59 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +14 lines, -13 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/spdy_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/spdy_utils.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 2 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-25 20:54:16 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1006193003/diff/20001/net/tools/quic/quic_spdy_client_stream.cc File net/tools/quic/quic_spdy_client_stream.cc (right): https://codereview.chromium.org/1006193003/diff/20001/net/tools/quic/quic_spdy_client_stream.cc#newcode5 net/tools/quic/quic_spdy_client_stream.cc:5: nit: extra blank line. https://codereview.chromium.org/1006193003/diff/20001/net/tools/quic/test_tools/quic_test_client.cc File net/tools/quic/test_tools/quic_test_client.cc (right): ...
5 years, 9 months ago (2015-03-25 21:06:22 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/1006193003/diff/20001/net/tools/quic/quic_spdy_client_stream.cc File net/tools/quic/quic_spdy_client_stream.cc (right): https://codereview.chromium.org/1006193003/diff/20001/net/tools/quic/quic_spdy_client_stream.cc#newcode5 net/tools/quic/quic_spdy_client_stream.cc:5: On 2015/03/25 21:06:21, ramant wrote: > nit: extra ...
5 years, 9 months ago (2015-03-25 21:37:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006193003/40001
5 years, 9 months ago (2015-03-25 21:38:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 22:21:08 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:21:51 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40fa174740fe5c16d4e1377bad45791206b8bae7
Cr-Commit-Position: refs/heads/master@{#322246}

Powered by Google App Engine
This is Rietveld 408576698