src/core/SkPictureShader.cpp - Issue 1006173005: add SkMatrix::decomposeScale

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPictureShader.cpp

Issue 1006173005: add SkMatrix::decomposeScale (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add unittest Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPictureShader.cpp

diff --git a/src/core/SkPictureShader.cpp b/src/core/SkPictureShader.cpp

index 776fe5e6556aa0c0b6ab846f73ffef787cecdc8f..3734791ce456581b69544c131fee440e52ba9e83 100644

--- a/src/core/SkPictureShader.cpp

+++ b/src/core/SkPictureShader.cpp

@@ -152,6 +152,9 @@ SkShader* SkPictureShader::refBitmapShader(const SkMatrix& matrix, const SkMatri

// Use a rotation-invariant scale

SkPoint scale;

+ //

+ // TODO: replace this with decomposeScale() -- but beware LayoutTest rebaselines!

+ //

if (!SkDecomposeUpper2x2(m, NULL, &scale, NULL)) {

// Decomposition failed, use an approximation.

scale.set(SkScalarSqrt(m.getScaleX() * m.getScaleX() + m.getSkewX() * m.getSkewX()),

« no previous file with comments | « src/core/SkMatrix.cpp ('k') | tests/MatrixTest.cpp » ('j') | no next file with comments »