Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1006173003: [stubs] Add missing interface descriptor for the CompareIC. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add missing interface descriptor for the CompareIC. R=jarin@chromium.org Committed: https://crrev.com/e18e3cd4d88f35f3690d2993ac1702b65edde54f Cr-Commit-Position: refs/heads/master@{#27305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-19 12:48:07 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-19 12:48:22 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-19 13:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006173003/1
5 years, 9 months ago (2015-03-19 13:04:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:09:30 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:09:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e18e3cd4d88f35f3690d2993ac1702b65edde54f
Cr-Commit-Position: refs/heads/master@{#27305}

Powered by Google App Engine
This is Rietveld 408576698