Issue 1006143003: Add an HTTP cache to SkyShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1006143003: Add an HTTP cache to SkyShell (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
ojan

CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add an HTTP cache to SkyShell This CL makes two changes to SkyShell's HTTP stack: 1) It introduces a disk cache so that responses can be loaded off disk instead of off the network. 2) It makes different instances of NetworkServiceImpl share the same OkHttpContext. Specifically, this means that network requests initiated from Dart share the same cache and connection pool as requests initiated from C++. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/463d3c512c8c1e18a0e3b75e4d222c4551c35e77

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java	View		3 chunks	+21 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 9 months ago (2015-03-24 19:45:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
463d3c512c8c1e18a0e3b75e4d222c4551c35e77 (presubmit successful).

Expand Messages | Collapse Messages