Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: gpu/command_buffer/service/gpu_tracer_unittest.cc

Issue 1006093002: Collapsed gl query functions with their ARB/EXT variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed gles2 decoder tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gpu_tracer_unittest.cc
diff --git a/gpu/command_buffer/service/gpu_tracer_unittest.cc b/gpu/command_buffer/service/gpu_tracer_unittest.cc
index 48a4db9943403f1c9b80a39c452a9f2085bbb68c..65fc9976abe966d73f80c9d05b680b492c468875 100644
--- a/gpu/command_buffer/service/gpu_tracer_unittest.cc
+++ b/gpu/command_buffer/service/gpu_tracer_unittest.cc
@@ -61,14 +61,14 @@ class GlFakeQueries {
void SetCurrentGLTime(GLint64 current_time) { current_time_ = current_time; }
void SetDisjoint() { disjointed_ = true; }
- void GenQueriesARB(GLsizei n, GLuint* ids) {
+ void GenQueries(GLsizei n, GLuint* ids) {
for (GLsizei i = 0; i < n; i++) {
ids[i] = next_query_id_++;
alloced_queries_.insert(ids[i]);
}
}
- void DeleteQueriesARB(GLsizei n, const GLuint* ids) {
+ void DeleteQueries(GLsizei n, const GLuint* ids) {
for (GLsizei i = 0; i < n; i++) {
alloced_queries_.erase(ids[i]);
query_timestamp_.erase(ids[i]);
@@ -237,9 +237,9 @@ class BaseGpuTest : public GpuServiceTest {
if (gpu_timing_client_->IsAvailable() &&
gpu_timing_client_->IsTimerOffsetAvailable()) {
// Delegate query APIs used by GPUTrace to a GlFakeQueries
- EXPECT_CALL(*gl_, GenQueriesARB(2, NotNull())).Times(AtLeast(1))
+ EXPECT_CALL(*gl_, GenQueries(2, NotNull())).Times(AtLeast(1))
.WillRepeatedly(
- Invoke(&gl_fake_queries_, &GlFakeQueries::GenQueriesARB));
+ Invoke(&gl_fake_queries_, &GlFakeQueries::GenQueries));
EXPECT_CALL(*gl_, GetQueryObjectivARB(_, GL_QUERY_RESULT_AVAILABLE,
NotNull()))
@@ -259,9 +259,9 @@ class BaseGpuTest : public GpuServiceTest {
Invoke(&gl_fake_queries_,
&GlFakeQueries::GetQueryObjectui64v));
- EXPECT_CALL(*gl_, DeleteQueriesARB(2, NotNull())).Times(AtLeast(1))
+ EXPECT_CALL(*gl_, DeleteQueries(2, NotNull())).Times(AtLeast(1))
.WillRepeatedly(
- Invoke(&gl_fake_queries_, &GlFakeQueries::DeleteQueriesARB));
+ Invoke(&gl_fake_queries_, &GlFakeQueries::DeleteQueries));
}
}

Powered by Google App Engine
This is Rietveld 408576698