Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1006053002: Allow Effen Styles to be extendable (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : moar #

Total comments: 1

Patch Set 3 : cr #

Total comments: 1

Patch Set 4 : one moar time #

Patch Set 5 : sigh #

Patch Set 6 : wee #

Patch Set 7 : sdfsd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -76 lines) Patch
M sky/examples/stocks-fn/stockarrow.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks-fn/stockrow.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/examples/stocks-fn/stocksapp.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/framework/components/button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/checkbox.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/drawer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/drawer_header.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/floating_action_button.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M sky/framework/components/icon.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/input.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/material.dart View 3 chunks +9 lines, -11 lines 0 comments Download
M sky/framework/components/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/menu_item.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/radio.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/toolbar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/editing/editable_text.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/framework/fn.dart View 1 2 3 4 5 7 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rafaelw
5 years, 9 months ago (2015-03-13 20:16:12 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/1006053002/diff/20001/sky/examples/stocks-fn/stocks.sky File sky/examples/stocks-fn/stocks.sky (right): https://codereview.chromium.org/1006053002/diff/20001/sky/examples/stocks-fn/stocks.sky#newcode3 sky/examples/stocks-fn/stocks.sky:3: <!-- <import src="/sky/framework/debug/shake-to-reload.sky" /> --> Did you mean ...
5 years, 9 months ago (2015-03-13 20:47:40 UTC) #3
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-13 21:08:11 UTC) #4
rafaelw
5 years, 9 months ago (2015-03-13 21:08:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #7 (id:110001) manually as
c5390756dae416e144335795ec4783c6a60f1b6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698