Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 100603002: Add aura::WindowIdRegistry. (Closed)

Created:
7 years ago by Sergey Ulanov
Modified:
7 years ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Add aura::WindowIdRegistry. WindowIdRegistry will be used to create and resolve unique identifiers for aura::Window instances. It's is needed for Desktop Capture API to identify capture targets. BUG=295102

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/aura/window_id_registry.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ui/aura/window_id_registry.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
7 years ago (2013-12-03 00:16:19 UTC) #1
Ben Goodger (Google)
How do you intend this to be used? Can you show some sample/pseudo code for ...
7 years ago (2013-12-03 00:34:18 UTC) #2
Sergey Ulanov
On 2013/12/03 00:34:18, Ben Goodger (Google) wrote: > How do you intend this to be ...
7 years ago (2013-12-03 01:52:37 UTC) #3
sky
Seems like a better approach is to have a delegate method that chrome implements that ...
7 years ago (2013-12-03 17:12:07 UTC) #4
Sergey Ulanov
7 years ago (2013-12-04 02:53:15 UTC) #5
Ok, closing this CL. I'll implement this logic in the content layer, inside
content::DesktopMediaID.

On 2013/12/03 17:12:07, sky wrote:
> Seems like a better approach is to have a delegate method that chrome
> implements that does the mapping. That way code can live entirely in
> chrome.
> 
>   -Scott
> 
> On Mon, Dec 2, 2013 at 5:52 PM,  <mailto:sergeyu@chromium.org> wrote:
> > On 2013/12/03 00:34:18, Ben Goodger (Google) wrote:
> >>
> >> How do you intend this to be used? Can you show some sample/pseudo code
> >> for a
> >> call site as well as other changes that might be needed in ui/aura?
> >
> >
> >> In general we've tried to keep the aura layer very small.
> >
> >
> > Here are two CLs where I'm using the new class:
> > https://codereview.chromium.org/100743003/
> > https://codereview.chromium.org/100833002/
> > Basically the problem is that for Desktop Capture API the windows picker UI
> > has
> > to be implemented in the Chrome layer, while the capture code itself is in
> > the
> > content layer
> > (content/browser/renderer_host/media/desktop_capture_device_ash.cc). So we
> > need
> > some way to pass ID of the window selected by the user from chrome to
> > content.
> > Alternatively this code can be placed in src/content/public, but I don't
> > think
> > it's the right thing to do. Aura layer seems to be a better place for it.
> > Also
> > having stable window ID might be useful for other features.
> >
> > https://codereview.chromium.org/100603002/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698