Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: Source/core/layout/LayoutButton.h

Issue 1006023002: Button elements are clipping overflow by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/linux/fast/forms/control-clip-overflow-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutButton.h
diff --git a/Source/core/layout/LayoutButton.h b/Source/core/layout/LayoutButton.h
index 517dc2427d3efb3fc35e5a8956b0d95d670be2d6..28d34cce8d55e4e58531f65f66fba59675206ee6 100644
--- a/Source/core/layout/LayoutButton.h
+++ b/Source/core/layout/LayoutButton.h
@@ -46,7 +46,7 @@ public:
virtual bool createsAnonymousWrapper() const override { return true; }
virtual bool canHaveGeneratedChildren() const override;
- virtual bool hasControlClip() const override { return true; }
+ virtual bool hasControlClip() const override { return !isHTMLButtonElement(node()); }
leviw_travelin_and_unemployed 2015/03/17 10:18:34 Can you put the implementation in LayoutButton.cpp
virtual LayoutRect controlClipRect(const LayoutPoint&) const override;
virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode) const override;
« no previous file with comments | « LayoutTests/platform/linux/fast/forms/control-clip-overflow-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698