Button elements are clipping overflow by default

Button elements are clipping overflow by default

Stop clipping overflow by default on button elements. This feature is
desirable only for input elements.

This makes us compatible with FF/Trident.

BUG=465429
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193213

[rhogan, 2015-03-14 16:38:13]

robhogan@gmail.com changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-03-17 10:18:34]

fast/forms/control-clip.html's description is no longer accurate, as it
overflows the yellow border.

Is there a specific test for the overflowing input type case?

https://codereview.chromium.org/1006023002/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutButton.h (right):

https://codereview.chromium.org/1006023002/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutButton.h:49: virtual bool hasControlClip() const
override { return !isHTMLButtonElement(node()); }
Can you put the implementation in LayoutButton.cpp (we can't inline virtual
functions anyways) and add a comment?

[rhogan, 2015-04-03 15:05:42]

On 2015/03/17 at 10:18:34, leviw wrote:
> fast/forms/control-clip.html's description is no longer accurate, as it
overflows the yellow border.
> 
> Is there a specific test for the overflowing input type case?
> 

Yes, fast/forms/001.html covers this.

[leviw_travelin_and_unemployed, 2015-04-04 01:42:28]

Looks like you need a couple more needs-rebaselines: 

virtual/slimmingpaint/fast/forms/control-clip-overflow.html
virtual/slimmingpaint/fast/forms/control-clip.html

LGTM... but I do have some suspicion that this'll cause some site issues.

[rhogan, 2015-04-06 19:01:23]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-04-06 19:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1006023002/#ps100001
(title: "Updated")

[commit-bot: I haz the power, 2015-04-06 19:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1006023002/100001

[commit-bot: I haz the power, 2015-04-06 19:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-06 19:04:59]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50639)

[rhogan, 2015-04-06 19:26:41]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-04-06 19:26:42]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1006023002/#ps120001
(title: "Updated")

[commit-bot: I haz the power, 2015-04-06 19:26:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1006023002/120001

[commit-bot: I haz the power, 2015-04-06 21:00:47]

Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193213