Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1006003005: Store the callstack of the IPC sender of ViewMsg_New. (Closed)

Created:
5 years, 9 months ago by lfg
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store the callstack of the IPC sender of ViewMsg_New. This is a temporary change to help track down the bug below, where we try to create a second RenderView with the same routing id in the same process. This CL fixes the previous CL where some of the data got optimized out by the compiler. BUG=464633 Committed: https://crrev.com/f032c0d065a5387a2e490e45bbec046e5a1bda61 Cr-Commit-Position: refs/heads/master@{#321024}

Patch Set 1 #

Total comments: 1

Patch Set 2 : adding comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lfg
Hi Nasko, please take a look.
5 years, 9 months ago (2015-03-17 22:24:22 UTC) #2
nasko
Was the debug::Alias() call not enough for the compiler to not optimize out the code? ...
5 years, 9 months ago (2015-03-17 22:45:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006003005/20001
5 years, 9 months ago (2015-03-17 23:51:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 00:14:09 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 00:14:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f032c0d065a5387a2e490e45bbec046e5a1bda61
Cr-Commit-Position: refs/heads/master@{#321024}

Powered by Google App Engine
This is Rietveld 408576698