Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1006003003: Adding a chrome flag to control the touch selection granularity strategy used by Blink. (Closed)

Created:
5 years, 9 months ago by mfomitchev
Modified:
4 years, 8 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unified_text_selection_ALL_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a chrome flag to control the touch selection granularity strategy used by Blink. Prerequisite CL: https://codereview.chromium.org/988023005/ BUG=451255

Patch Set 1 #

Patch Set 2 : Removing logging. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +14 lines, -0 lines 2 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jdduke (slow)
https://codereview.chromium.org/1006003003/diff/20001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/1006003003/diff/20001/chrome/browser/about_flags.cc#newcode179 chrome/browser/about_flags.cc:179: switches::kTouchTextSelectionStrategy, I'd be OK if we just called this ...
5 years, 8 months ago (2015-04-17 15:20:29 UTC) #2
mfomitchev
5 years, 8 months ago (2015-04-17 16:22:39 UTC) #3 
https://codereview.chromium.org/1006003003/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1006003003/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:179: switches::kTouchTextSelectionStrategy,
On 2015/04/17 15:20:29, jdduke wrote:
> I'd be OK if we just called this |kEnableSmartTextSelection| or something like
> that. Not sure we even need it in about:flags, but if we do add it here we
might
> restrict the OS to where it will be available (Android).

You are a bit ahead of me. Check out
https://codereview.chromium.org/1096773002/.

Powered by Google App Engine
This is Rietveld 408576698