Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1005953003: Reland "Re-enable the new SQLitePersistentCookieStore load strategy." (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Re-enable the new SQLitePersistentCookieStore load strategy." Reason for revert: The source of the crash was another bug in SequencedWorkerPool. I just landed a fix for that: https://codereview.chromium.org/994483005/ So I'm going to reland this CL. Original issue's description: > Revert of Re-enable the new SQLitePersistentCookieStore load strategy. (patchset #1 id:1 of https://codereview.chromium.org/953993002/) > > Reason for revert: > This CL causes hangs during shutdown. > > https://code.google.com/p/chromium/issues/detail?id=465271 > > Original issue's description: > > Re-enable the new SQLitePersistentCookieStore load strategy. > > > > When I first turned on the new load strategy, it caused deadlocks during > > shutdown. I found and fixed the bug in SequencedWorkerPool. > > > > BUG=448910 > > > > Committed: https://crrev.com/043d6b497dda7a39138eca1fb9df89ee340e543b > > Cr-Commit-Position: refs/heads/master@{#318305} > > TBR=erikwright@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=448910 > > Committed: https://crrev.com/24ab88b28d3fcdb67a919527e67c49ba5d55ed93 > Cr-Commit-Position: refs/heads/master@{#319696} TBR=erikwright@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448910 Committed: https://crrev.com/ecd42cf5ae19e2807067ad1add9430af0d34510d Cr-Commit-Position: refs/heads/master@{#320605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
erikchen
Created Revert of Revert of Re-enable the new SQLitePersistentCookieStore load strategy.
5 years, 9 months ago (2015-03-13 23:47:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005953003/1
5 years, 9 months ago (2015-03-13 23:48:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 23:49:51 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 23:50:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecd42cf5ae19e2807067ad1add9430af0d34510d
Cr-Commit-Position: refs/heads/master@{#320605}

Powered by Google App Engine
This is Rietveld 408576698