Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: components/history/core/browser/top_sites_backend.cc

Issue 1005873011: Only record the execution time during startup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the static to TopSitesImpl Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/top_sites_backend.cc
diff --git a/components/history/core/browser/top_sites_backend.cc b/components/history/core/browser/top_sites_backend.cc
index 2383c1c9d213510dc217bc28465667d05dda2392..89880b4be3df70da1565fa50170ad0fc3d1d995c 100644
--- a/components/history/core/browser/top_sites_backend.cc
+++ b/components/history/core/browser/top_sites_backend.cc
@@ -47,10 +47,12 @@ void TopSitesBackend::GetMostVisitedThumbnails(
base::Bind(callback, thumbnails));
}
-void TopSitesBackend::UpdateTopSites(const TopSitesDelta& delta) {
+void TopSitesBackend::UpdateTopSites(const TopSitesDelta& delta,
+ const RecordHistogram record_or_not) {
db_task_runner_->PostTask(
FROM_HERE,
- base::Bind(&TopSitesBackend::UpdateTopSitesOnDBThread, this, delta));
+ base::Bind(&TopSitesBackend::UpdateTopSitesOnDBThread, this, delta,
+ record_or_not));
}
void TopSitesBackend::SetPageThumbnail(const MostVisitedURL& url,
@@ -101,14 +103,13 @@ void TopSitesBackend::GetMostVisitedThumbnailsOnDBThread(
}
}
-void TopSitesBackend::UpdateTopSitesOnDBThread(const TopSitesDelta& delta) {
+void TopSitesBackend::UpdateTopSitesOnDBThread(
+ const TopSitesDelta& delta, const RecordHistogram record_or_not) {
TRACE_EVENT0("startup", "history::TopSitesBackend::UpdateTopSitesOnDBThread");
if (!db_)
return;
- // TODO(yiyaoliu): Remove the histogram and related code when crbug/223430 is
- // fixed.
base::TimeTicks begin_time = base::TimeTicks::Now();
for (size_t i = 0; i < delta.deleted.size(); ++i)
@@ -120,8 +121,10 @@ void TopSitesBackend::UpdateTopSitesOnDBThread(const TopSitesDelta& delta) {
for (size_t i = 0; i < delta.moved.size(); ++i)
db_->UpdatePageRank(delta.moved[i].url, delta.moved[i].rank);
- UMA_HISTOGRAM_TIMES("History.UpdateTopSitesOnDBThreadTime",
- base::TimeTicks::Now() - begin_time);
+ if (record_or_not == RECORD_HISTOGRAM_YES) {
+ UMA_HISTOGRAM_TIMES("History.UpdateTopSitesOnDBThread_Startup_Time",
sky 2015/04/17 15:07:02 This name is a bit misleading too. Maybe something
yao 2015/04/17 15:42:51 Done.
+ base::TimeTicks::Now() - begin_time);
+ }
}
void TopSitesBackend::SetPageThumbnailOnDBThread(const MostVisitedURL& url,

Powered by Google App Engine
This is Rietveld 408576698