Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/browser/history/top_sites_impl.h

Issue 1005873011: Only record the execution time during startup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/top_sites_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/top_sites_impl.h
diff --git a/chrome/browser/history/top_sites_impl.h b/chrome/browser/history/top_sites_impl.h
index 91518ec742b6ed79931882101310133b1e8b61cd..68d3d78379ee2d0415fda105afc562c7f1c3f18e 100644
--- a/chrome/browser/history/top_sites_impl.h
+++ b/chrome/browser/history/top_sites_impl.h
@@ -195,7 +195,10 @@ class TopSitesImpl : public TopSites,
// if the list of forced URLs overflows, the oldest ones are dropped.
// All mutations to cache_ *must* go through this. Should
// be called from the UI thread.
- void SetTopSites(const MostVisitedURLList& new_top_sites);
+ // The bool param is used for knowing weather this function is called during
rkaplow 2015/03/27 02:33:28 whether
yao 2015/03/27 18:39:45 Done.
+ // startup or not, thus histogram value could be recorded accordingly.
+ // TODO(yiyaoliu): Remove this when crbug/223430 is fixed.
+ void SetTopSites(const MostVisitedURLList& new_top_sites, bool startup);
rkaplow 2015/03/27 02:33:28 it seems kind of messy to me to measure it with a
yao 2015/03/27 18:39:45 It's possible if we only care about execution time
// Returns the number of most visited results to request from history. This
// changes depending upon how many urls have been blacklisted. Should be
« no previous file with comments | « no previous file | chrome/browser/history/top_sites_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698