Only record the execution time during startup.

components/history/core/browser/top_sites_backend.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/top_sites_backend.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
 #include "base/location.h"
 #include "base/memory/ref_counted.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "components/history/core/browser/top_sites_database.h"
 #include "sql/connection.h"
 
 namespace history {
 
+TopSitesBackend::HistogramRecording TopSitesBackend::histogram_recorded_ =
+    HISTOGRAM_RECORDING_NOT_YET;
+
+// static
+void TopSitesBackend::IncraseHistogramRecordingStatus() {
+  if (histogram_recorded_ == HISTOGRAM_RECORDING_NOT_YET) {
+    histogram_recorded_ = HISTOGRAM_RECORDING_IN_PROGRESS;
+  } else if (histogram_recorded_ == HISTOGRAM_RECORDING_IN_PROGRESS) {
+    histogram_recorded_ = HISTOGRAM_RECORDING_DONE;
+  }
+}
+
 TopSitesBackend::TopSitesBackend(
     const scoped_refptr<base::SingleThreadTaskRunner>& db_task_runner)
     : db_(new TopSitesDatabase()), db_task_runner_(db_task_runner) {
   DCHECK(db_task_runner_);
 }
 
 void TopSitesBackend::Init(const base::FilePath& path) {
   db_path_ = path;
   db_task_runner_->PostTask(
       FROM_HERE, base::Bind(&TopSitesBackend::InitDBOnDBThread, this, path));
 }
 
 void TopSitesBackend::Shutdown() {
   db_task_runner_->PostTask(
       FROM_HERE, base::Bind(&TopSitesBackend::ShutdownDBOnDBThread, this));
 }
 
 void TopSitesBackend::GetMostVisitedThumbnails(
     const GetMostVisitedThumbnailsCallback& callback,
     base::CancelableTaskTracker* tracker) {
   scoped_refptr<MostVisitedThumbnails> thumbnails = new MostVisitedThumbnails();
   tracker->PostTaskAndReply(
       db_task_runner_.get(), FROM_HERE,
       base::Bind(&TopSitesBackend::GetMostVisitedThumbnailsOnDBThread, this,
                  thumbnails),
       base::Bind(callback, thumbnails));
 }
 
-void TopSitesBackend::UpdateTopSites(const TopSitesDelta& delta) {
+void TopSitesBackend::UpdateTopSites(const TopSitesDelta& delta,
+                                     const CallLocation location) {
   db_task_runner_->PostTask(
       FROM_HERE,
-      base::Bind(&TopSitesBackend::UpdateTopSitesOnDBThread, this, delta));
+      base::Bind(&TopSitesBackend::UpdateTopSitesOnDBThread, this, delta,
+                 location));
 }
 
 void TopSitesBackend::SetPageThumbnail(const MostVisitedURL& url,
                                        int url_rank,
                                        const Images& thumbnail) {
   db_task_runner_->PostTask(
       FROM_HERE, base::Bind(&TopSitesBackend::SetPageThumbnailOnDBThread, this,
                             url, url_rank, thumbnail));
 }
 
@@ skipping 30 matching lines @@
 void TopSitesBackend::GetMostVisitedThumbnailsOnDBThread(
     scoped_refptr<MostVisitedThumbnails> thumbnails) {
   DCHECK(db_task_runner_->BelongsToCurrentThread());
 
   if (db_) {
     db_->GetPageThumbnails(&(thumbnails->most_visited),
                            &(thumbnails->url_to_images_map));
   }
 }
 
-void TopSitesBackend::UpdateTopSitesOnDBThread(const TopSitesDelta& delta) {
+void TopSitesBackend::UpdateTopSitesOnDBThread(
+    const TopSitesDelta& delta, const CallLocation location) {
   TRACE_EVENT0("startup", "history::TopSitesBackend::UpdateTopSitesOnDBThread");
 
   if (!db_)
     return;
 
   // TODO(yiyaoliu): Remove the histogram and related code when crbug/223430 is
   // fixed.
   base::TimeTicks begin_time = base::TimeTicks::Now();
 
   for (size_t i = 0; i < delta.deleted.size(); ++i)
     db_->RemoveURL(delta.deleted[i]);
 
   for (size_t i = 0; i < delta.added.size(); ++i)
     db_->SetPageThumbnail(delta.added[i].url, delta.added[i].rank, Images());
 
   for (size_t i = 0; i < delta.moved.size(); ++i)
     db_->UpdatePageRank(delta.moved[i].url, delta.moved[i].rank);
 
-  UMA_HISTOGRAM_TIMES("History.UpdateTopSitesOnDBThreadTime",
-                      base::TimeTicks::Now() - begin_time);
+  // If this is initiated from TopSitesImpl::OnGotMostVisitedThumbnails, and
+  // |histogram_recorded_| indicates that the histogram recording is in
+  // progress, records the function execution time.
+  if (location == CALL_LOCATION_FROM_ON_GOT_MOST_VISITED_THUMBNAILS &&
+      histogram_recorded_ == HISTOGRAM_RECORDING_IN_PROGRESS) {
+    UMA_HISTOGRAM_TIMES("History.UpdateTopSitesOnDBThread_Startup_Time",
+                        base::TimeTicks::Now() - begin_time);
+    IncraseHistogramRecordingStatus();
+  }
 }
 
 void TopSitesBackend::SetPageThumbnailOnDBThread(const MostVisitedURL& url,
                                                  int url_rank,
                                                  const Images& thumbnail) {
   if (!db_)
     return;
 
   db_->SetPageThumbnail(url, url_rank, thumbnail);
 }
 
 void TopSitesBackend::ResetDatabaseOnDBThread(const base::FilePath& file_path) {
   DCHECK(db_task_runner_->BelongsToCurrentThread());
   db_.reset(NULL);
   sql::Connection::Delete(db_path_);
   db_.reset(new TopSitesDatabase());
   InitDBOnDBThread(db_path_);
 }
 
 }  // namespace history