Only record the execution time during startup.

components/history/core/browser/top_sites_backend.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_TOP_SITES_BACKEND_H_
 #define COMPONENTS_HISTORY_CORE_BROWSER_TOP_SITES_BACKEND_H_
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/history/core/browser/history_types.h"
 
 namespace base {
 class CancelableTaskTracker;
 class FilePath;
 class SingleThreadTaskRunner;
 }
 
 namespace history {
 
 class TopSitesDatabase;
 
 // Service used by TopSites to have db interaction happen on the DB thread.  All
 // public methods are invoked on the ui thread and get funneled to the DB
 // thread.
 class TopSitesBackend : public base::RefCountedThreadSafe<TopSitesBackend> {
  public:
+  // An enum representing different situations under which function
+  // TopSitesImpl::SetTopSites and TopSitesBackend::UpdateTopSites can be
+  // initiated.
+  // This is needed because a histogram is used to record speed related metrics
+  // when TopSitesImpl::SetTopSites and TopSitesBackend::UpdateTopSites are
+  // initiated from TopSitesImpl::OnGotMostVisitedThumbnails, which usually
+  // happens early and might affect Chrome startup speed.
+  // TODO(yiyaoliu): Remove this when crbug/223430 is fixed.
+  enum TopSitesCalledLocation {

[sky, 2015/04/01 22:51:48]

This is in the topsites files, so prefixing with topsites just makes this more
verbose. How about CallLocation

[yao, 2015/04/02 17:20:31]

Done.

+    // SetTopSites is called when MostVisitedThumbnails is available (function
+    // TopSitesImpl::OnGotMostVisitedThumbnails).
+    fromOnGotMostVisitedThumbnails,

[sky, 2015/04/01 22:51:48]

Style guide says enums are ALL_CAPS. And generally we prefix with name of enum,
eg CALL_LOCATION_FROM_ON_GOT_MOST_VISITED_THUMBNAILS.

[yao, 2015/04/02 17:20:31]

Done.

+    // All other situations.
+    fomOtherPlaces
+  };
+
   // The boolean parameter indicates if the DB existed on disk or needs to be
   // migrated.
   typedef base::Callback<void(const scoped_refptr<MostVisitedThumbnails>&)>
       GetMostVisitedThumbnailsCallback;
 
   explicit TopSitesBackend(
       const scoped_refptr<base::SingleThreadTaskRunner>& db_task_runner);
 
   void Init(const base::FilePath& path);
 
   // Schedules the db to be shutdown.
   void Shutdown();
 
   // Fetches MostVisitedThumbnails.
   void GetMostVisitedThumbnails(
       const GetMostVisitedThumbnailsCallback& callback,
       base::CancelableTaskTracker* tracker);
 
   // Updates top sites database from the specified delta.
-  void UpdateTopSites(const TopSitesDelta& delta);
+  // TODO(yiyaoliu): Remove the 2nd parameter when crbug/223430 is fixed.
+  void UpdateTopSites(const TopSitesDelta& delta,
+                      const TopSitesCalledLocation location);
 
   // Sets the thumbnail.
   void SetPageThumbnail(const MostVisitedURL& url,
                         int url_rank,
                         const Images& thumbnail);
 
   // Deletes the database and recreates it.
   void ResetDatabase();
 
   // Schedules a request that does nothing on the DB thread, but then notifies
@@ skipping 11 matching lines @@
   void InitDBOnDBThread(const base::FilePath& path);
 
   // Shuts down the db.
   void ShutdownDBOnDBThread();
 
   // Does the work of getting the most visted thumbnails.
   void GetMostVisitedThumbnailsOnDBThread(
       scoped_refptr<MostVisitedThumbnails> thumbnails);
 
   // Updates top sites.
-  void UpdateTopSitesOnDBThread(const TopSitesDelta& delta);
+  // TODO(yiyaoliu): Remove the 2nd parameter when crbug/223430 is fixed.
+  void UpdateTopSitesOnDBThread(const TopSitesDelta& delta,
+                                const TopSitesCalledLocation location);
 
   // Sets the thumbnail.
   void SetPageThumbnailOnDBThread(const MostVisitedURL& url,
                                   int url_rank,
                                   const Images& thumbnail);
 
   // Resets the database.
   void ResetDatabaseOnDBThread(const base::FilePath& file_path);
 
   base::FilePath db_path_;
 
   scoped_ptr<TopSitesDatabase> db_;
   scoped_refptr<base::SingleThreadTaskRunner> db_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(TopSitesBackend);
 };
 
 }  // namespace history
 
 #endif  // COMPONENTS_HISTORY_CORE_BROWSER_TOP_SITES_BACKEND_H_