Add a print function in the global JS scope for debugging.

Add a print function in the global JS scope for debugging.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12695

[robertphillips, 2013-12-16 19:22:59]

lgtm + nits & a question

https://codereview.chromium.org/100583005/diff/1/experimental/SkV8Example/SkV...
File experimental/SkV8Example/SkV8Example.cpp (right):

https://codereview.chromium.org/100583005/diff/1/experimental/SkV8Example/SkV...
experimental/SkV8Example/SkV8Example.cpp:299: void Print(const
v8::FunctionCallbackInfo<v8::Value>& args) {
2 space tabs?

https://codereview.chromium.org/100583005/diff/1/experimental/SkV8Example/SkV...
experimental/SkV8Example/SkV8Example.cpp:301: for (int i = 0; i < args.Length();
i++) {
handleScope?
Can this not be done outside the loop?

[jcgregorio, 2013-12-16 19:33:15]

https://codereview.chromium.org/100583005/diff/1/experimental/SkV8Example/SkV...
File experimental/SkV8Example/SkV8Example.cpp (right):

https://codereview.chromium.org/100583005/diff/1/experimental/SkV8Example/SkV...
experimental/SkV8Example/SkV8Example.cpp:299: void Print(const
v8::FunctionCallbackInfo<v8::Value>& args) {
On 2013/12/16 19:23:00, robertphillips wrote:
> 2 space tabs?

Done.

https://codereview.chromium.org/100583005/diff/1/experimental/SkV8Example/SkV...
experimental/SkV8Example/SkV8Example.cpp:301: for (int i = 0; i < args.Length();
i++) {
On 2013/12/16 19:23:00, robertphillips wrote:
> handleScope?
> Can this not be done outside the loop?

It can, at least the code compiles and runs, so I changed it to that :-)

I had it in the loop like in this v8 sample:

  http://v8.googlecode.com/svn/trunk/samples/shell.cc

Maybe that frees up memory sooner?

[commit-bot: I haz the power, 2013-12-16 19:33:27]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/100583005/20001

[commit-bot: I haz the power, 2013-12-16 19:46:25]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/100583005/20001

[commit-bot: I haz the power, 2013-12-16 19:55:05]

Change committed as 12695