Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1005753002: Scrollable should settle back to 0.0 (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel, ojan
CC:
ojan, hansmuller, mojo-reviews_chromium.org, qsr+mojo_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Scrollable should settle back to 0.0 This CL teaches Scrollable how to settle back to a scroll offset of 0.0 after a fling or a scroll. There's still some room for improvement: 1) Some of this logic should be factored out into the scroll curve object. 2) We don't produce the correct animation curves when we fling into the overscroll region because we wait for the fling velocity to reach zero before we start the settling animation. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ce1c56c8c532bae98e9b9ffb71e3a98d8cae1fe3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -12 lines) Patch
M sky/framework/animation/generator.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M sky/framework/components/scrollable.dart View 5 chunks +54 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-12 21:26:58 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-12 21:32:40 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-12 21:33:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce1c56c8c532bae98e9b9ffb71e3a98d8cae1fe3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698