Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100573003: [Mojo] Move JS bindings out of public (Closed)

Created:
7 years ago by abarth-chromium
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

[Mojo] Move JS bindings out of public This CL moves the implementation of Mojo's JavaScript bindings out of the "public" directory. The public directory is intended to be free of dependencies on other parts of Chromium, but the JavaScript bindings depend on V8 and base. Now, the bindings are just a subdirectory of mojo/apps/js, which is their only client. This makes mojo.js more of a self-contained app. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238476

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix header guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1587 lines) Patch
A + mojo/apps/js/bindings/codec.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/apps/js/bindings/codec_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/apps/js/bindings/connector.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/connector_unittests.js View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/apps/js/bindings/core.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/core.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/core_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/apps/js/bindings/handle.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/apps/js/bindings/support.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/support.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/apps/js/bindings/threading.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/apps/js/bindings/threading.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/waiting_callback.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/bindings/waiting_callback.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/main.js View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/apps/js/mojo_runner_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/apps/js/test/hexdump.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/apps/js/test/run_js_tests.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/apps/js/threading.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/apps/js/threading.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M mojo/mojo.gyp View 3 chunks +2 lines, -21 lines 0 comments Download
A mojo/mojo_apps.gypi View 1 chunk +59 lines, -0 lines 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +0 lines, -37 lines 0 comments Download
M mojo/public/bindings/generators/js_templates/module.js.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/public/bindings/js/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D mojo/public/bindings/js/codec.js View 1 chunk +0 lines, -445 lines 0 comments Download
D mojo/public/bindings/js/codec_unittests.js View 1 chunk +0 lines, -160 lines 0 comments Download
D mojo/public/bindings/js/connector.js View 1 chunk +0 lines, -97 lines 0 comments Download
D mojo/public/bindings/js/connector_unittests.js View 1 chunk +0 lines, -125 lines 0 comments Download
D mojo/public/bindings/js/core.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/public/bindings/js/core.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D mojo/public/bindings/js/core_unittests.js View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/public/bindings/js/handle.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/public/bindings/js/handle.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/public/bindings/js/support.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/public/bindings/js/support.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/public/bindings/js/test/hexdump.js View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/bindings/js/test/run_js_tests.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/public/bindings/js/waiting_callback.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/public/bindings/js/waiting_callback.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M mojo/public/bindings/sample/sample_service_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/mojob.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
7 years ago (2013-12-03 07:11:51 UTC) #1
abarth-chromium
https://codereview.chromium.org/100573003/diff/1/mojo/public/bindings/generators/js_templates/module.js.tmpl File mojo/public/bindings/generators/js_templates/module.js.tmpl (right): https://codereview.chromium.org/100573003/diff/1/mojo/public/bindings/generators/js_templates/module.js.tmpl#newcode7 mojo/public/bindings/generators/js_templates/module.js.tmpl:7: "mojo/apps/js/bindings/codec", The one odd thing with this arrangement is ...
7 years ago (2013-12-03 07:13:26 UTC) #2
darin (slow to review)
LGTM
7 years ago (2013-12-03 21:26:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/100573003/20001
7 years ago (2013-12-03 21:28:36 UTC) #4
abarth-chromium
7 years ago (2013-12-03 23:18:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r238476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698