Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: chrome/installer/setup/setup_util_unittest.cc

Issue 100573002: Move directory creation functions to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/copy_tree_work_item_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_util_unittest.cc
diff --git a/chrome/installer/setup/setup_util_unittest.cc b/chrome/installer/setup/setup_util_unittest.cc
index 3a02f28d32c2dc9b234b33675c956ab72d43a885..0e06efbe96705e50f27536f2ec0682953370d4e1 100644
--- a/chrome/installer/setup/setup_util_unittest.cc
+++ b/chrome/installer/setup/setup_util_unittest.cc
@@ -100,7 +100,7 @@ bool CurrentProcessHasPrivilege(const wchar_t* privilege_name) {
TEST_F(SetupUtilTestWithDir, GetMaxVersionFromArchiveDirTest) {
// Create a version dir
base::FilePath chrome_dir = test_dir_.path().AppendASCII("1.0.0.0");
- file_util::CreateDirectory(chrome_dir);
+ base::CreateDirectory(chrome_dir);
ASSERT_TRUE(base::PathExists(chrome_dir));
scoped_ptr<Version> version(
installer::GetMaxVersionFromArchiveDir(test_dir_.path()));
@@ -111,22 +111,22 @@ TEST_F(SetupUtilTestWithDir, GetMaxVersionFromArchiveDirTest) {
ASSERT_TRUE(installer::GetMaxVersionFromArchiveDir(test_dir_.path()) == NULL);
chrome_dir = test_dir_.path().AppendASCII("ABC");
- file_util::CreateDirectory(chrome_dir);
+ base::CreateDirectory(chrome_dir);
ASSERT_TRUE(base::PathExists(chrome_dir));
ASSERT_TRUE(installer::GetMaxVersionFromArchiveDir(test_dir_.path()) == NULL);
chrome_dir = test_dir_.path().AppendASCII("2.3.4.5");
- file_util::CreateDirectory(chrome_dir);
+ base::CreateDirectory(chrome_dir);
ASSERT_TRUE(base::PathExists(chrome_dir));
version.reset(installer::GetMaxVersionFromArchiveDir(test_dir_.path()));
ASSERT_EQ(version->GetString(), "2.3.4.5");
// Create multiple version dirs, ensure that we select the greatest.
chrome_dir = test_dir_.path().AppendASCII("9.9.9.9");
- file_util::CreateDirectory(chrome_dir);
+ base::CreateDirectory(chrome_dir);
ASSERT_TRUE(base::PathExists(chrome_dir));
chrome_dir = test_dir_.path().AppendASCII("1.1.1.1");
- file_util::CreateDirectory(chrome_dir);
+ base::CreateDirectory(chrome_dir);
ASSERT_TRUE(base::PathExists(chrome_dir));
version.reset(installer::GetMaxVersionFromArchiveDir(test_dir_.path()));
@@ -306,10 +306,10 @@ class FindArchiveToPatchTest : public SetupUtilTestWithDir {
// Create archives in the two version dirs.
ASSERT_TRUE(
- file_util::CreateDirectory(GetProductVersionArchivePath().DirName()));
+ base::CreateDirectory(GetProductVersionArchivePath().DirName()));
ASSERT_EQ(1, file_util::WriteFile(GetProductVersionArchivePath(), "a", 1));
ASSERT_TRUE(
- file_util::CreateDirectory(GetMaxVersionArchivePath().DirName()));
+ base::CreateDirectory(GetMaxVersionArchivePath().DirName()));
ASSERT_EQ(1, file_util::WriteFile(GetMaxVersionArchivePath(), "b", 1));
}
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/copy_tree_work_item_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698