Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: base/path_service.cc

Issue 100573002: Move directory creation functions to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/mac/mac_util_unittest.mm ('k') | base/test/launcher/test_results_tracker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/path_service.h" 5 #include "base/path_service.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 247
248 FilePath file_path = path; 248 FilePath file_path = path;
249 249
250 // For some locations this will fail if called from inside the sandbox there- 250 // For some locations this will fail if called from inside the sandbox there-
251 // fore we protect this call with a flag. 251 // fore we protect this call with a flag.
252 if (create) { 252 if (create) {
253 // Make sure the directory exists. We need to do this before we translate 253 // Make sure the directory exists. We need to do this before we translate
254 // this to the absolute path because on POSIX, MakeAbsoluteFilePath fails 254 // this to the absolute path because on POSIX, MakeAbsoluteFilePath fails
255 // if called on a non-existent path. 255 // if called on a non-existent path.
256 if (!base::PathExists(file_path) && 256 if (!base::PathExists(file_path) &&
257 !file_util::CreateDirectory(file_path)) 257 !base::CreateDirectory(file_path))
258 return false; 258 return false;
259 } 259 }
260 260
261 // We need to have an absolute path. 261 // We need to have an absolute path.
262 file_path = MakeAbsoluteFilePath(file_path); 262 file_path = MakeAbsoluteFilePath(file_path);
263 if (file_path.empty()) 263 if (file_path.empty())
264 return false; 264 return false;
265 265
266 base::AutoLock scoped_lock(path_data->lock); 266 base::AutoLock scoped_lock(path_data->lock);
267 267
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 327
328 // static 328 // static
329 void PathService::DisableCache() { 329 void PathService::DisableCache() {
330 PathData* path_data = GetPathData(); 330 PathData* path_data = GetPathData();
331 DCHECK(path_data); 331 DCHECK(path_data);
332 332
333 base::AutoLock scoped_lock(path_data->lock); 333 base::AutoLock scoped_lock(path_data->lock);
334 path_data->cache.clear(); 334 path_data->cache.clear();
335 path_data->cache_disabled = true; 335 path_data->cache_disabled = true;
336 } 336 }
OLDNEW
« no previous file with comments | « base/mac/mac_util_unittest.mm ('k') | base/test/launcher/test_results_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698