Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1005723003: First pass at a meta-build wrapper for the gyp->gn migration (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

First pass at a meta-build wrapper for the gyp->gn migration This patch adds a new tool called 'mb' that provides a single common interface wrapping both GYP and GN. The idea is that bots will call this and not need to worry about whether to use GYP or GN, and developers can use this to more easily manage multiple build directories that match supported configurations Full details can be found in tools/mb/docs/user_guide.md and tools/mb/docs/design_spec.md R=scottmg@chromium.org, brettw@chromium.org BUG=466436

Patch Set 1 #

Patch Set 2 : fix syntax errors in build/configs.pyl #

Patch Set 3 : update; gen works for basic things #

Patch Set 4 : clean up dryrun/verbose #

Patch Set 5 : fix typos #

Patch Set 6 : rename to mb, add docs #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+828 lines, -0 lines) Patch
A build/mb_conf.pyl View 1 2 3 4 5 1 chunk +70 lines, -0 lines 0 comments Download
A tools/mb/README.md View 1 2 3 4 5 1 chunk +22 lines, -0 lines 4 comments Download
A tools/mb/docs/design_spec.md View 1 2 3 4 5 1 chunk +312 lines, -0 lines 0 comments Download
A tools/mb/docs/user_guide.md View 1 2 3 4 5 1 chunk +90 lines, -0 lines 0 comments Download
A tools/mb/mb View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A tools/mb/mb.bat View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A tools/mb/mb.py View 1 2 3 4 5 1 chunk +320 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dirk Pranke
Please take a look, particularly at the design spec, to see what I am shooting ...
5 years, 8 months ago (2015-04-02 01:33:37 UTC) #2
scottmg
Seems generally OK. At a high level, it seems useful as a gyp<->gn switcher and ...
5 years, 8 months ago (2015-04-02 20:02:40 UTC) #3
Dirk Pranke
> I'm not overly enthused about using it in the "someday future" once we're > ...
5 years, 8 months ago (2015-04-02 21:16:16 UTC) #4
Dirk Pranke
5 years, 8 months ago (2015-04-08 16:10:03 UTC) #5
Message was sent while issue was closed.
Closing; this was superceded by a more bot-focused variant in
https://codereview.chromium.org/1062613004/.

Powered by Google App Engine
This is Rietveld 408576698