Issue 1005693008: Files.app: Improve importer error catcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1005693008: Files.app: Improve importer error catcher. (Closed)

Created:
5 years, 9 months ago by Ben Kwa

Modified:
5 years, 9 months ago

Reviewers:
Steve McKay

CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Improve importer error catcher. - Fix a bug where stacks weren't getting printed. - Remove throwing of errors - the error catcher should catch but not re-throw errors. BUG=None Committed: https://crrev.com/128fddc8e9fa0e74f41d152c7cd62c0c31275ebe Cr-Commit-Position: refs/heads/master@{#321880}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	ui/file_manager/file_manager/common/js/importer_common.js	View		1 chunk	+8 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005693008/1

5 years, 9 months ago (2015-03-23 22:15:10 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-23 22:47:21 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/128fddc8e9fa0e74f41d152c7cd62c0c31275ebe
Cr-Commit-Position: refs/heads/master@{#321880}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages