Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1005693005: Add unittests for the HostContentSettingsMap's provider for Supervised Users. (Closed)

Created:
5 years, 9 months ago by knn
Modified:
5 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unittests for the HostContentSettingsMap's provider for Supervised Users. BUG=455646 Committed: https://crrev.com/fafc200a25ac410af7d7def1c32e9e6526fdfd63 Cr-Commit-Position: refs/heads/master@{#321830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
A chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc View 1 chunk +121 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
knn
Tests for https://codereview.chromium.org/902833003
5 years, 9 months ago (2015-03-23 17:12:15 UTC) #2
Bernhard Bauer
LGTM, thanks!
5 years, 9 months ago (2015-03-23 17:36:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005693005/1
5 years, 9 months ago (2015-03-23 17:52:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/48155)
5 years, 9 months ago (2015-03-23 17:59:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005693005/1
5 years, 9 months ago (2015-03-23 19:30:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 19:31:13 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 19:32:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fafc200a25ac410af7d7def1c32e9e6526fdfd63
Cr-Commit-Position: refs/heads/master@{#321830}

Powered by Google App Engine
This is Rietveld 408576698