pylib/gyp/generator/ninja.py - Issue 1005693004: Assert when source is an absolute path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 1005693004: Assert when source is an absolute path (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index 09df83f2192cf45676467ac1fd744e1fe5b4053f..6823f4ffbdaf25ad8676650f65e55cd3e58b2a30 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -330,6 +330,9 @@ class NinjaWriter(object):

obj += '.' + self.toolset

path_dir, path_basename = os.path.split(path)

+ assert not os.path.isabs(path_dir), (

+ "'%s' can not be absolute path (see crbug.com/462153)." % path_dir)

if qualified:

path_basename = self.name + '.' + path_basename

return os.path.normpath(os.path.join(obj, self.base_dir, path_dir,

« no previous file with comments | « no previous file | no next file » | no next file with comments »