Issue 1005693004: Assert when source is an absolute path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1005693004: Assert when source is an absolute path (Closed)

Created:
5 years, 9 months ago by bradn

Modified:
5 years, 9 months ago

Reviewers:
Fabrice (no longer in Chrome), Yang Gu, Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Target Ref:
refs/remotes/origin/master

Project:
gyp

Visibility:
Public.

Assert when source is an absolute path If the path passed to GypPathToUniqueOutput() is an absolute path, the output path is absolute too, instead of one starting from obj directory. Any intermediate file not residing in obj directory would cause problem and this CL adds an assertion. BUG=462153 TBR=thakis@chromium.org,yang.gu@intel.com,fdegans@chromium.org Landing this change on behalf of Yang Gu: https://codereview.chromium.org/967443002/ Committed: https://chromium.googlesource.com/external/gyp/+/e1c8fcf74b68637ba632f9fdfa77be088924b850

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

bradn

5 years, 9 months ago (2015-03-19 23:15:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e1c8fcf74b68637ba632f9fdfa77be088924b850 (presubmit successful).