content/browser/service_worker/service_worker_registration.cc - Issue 1005683003: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 1005683003: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_internals_ui.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index eba1997a7d5566ae516242c61734906eddb110d8..f436f95c38f488003d691e93a13abbf5043b2915 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -34,13 +34,13 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(

should_activate_when_ready_(false),

resources_total_size_bytes_(0),

context_(context) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(context_);

context_->AddLiveRegistration(this);

}

ServiceWorkerRegistration::~ServiceWorkerRegistration() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(!listeners_.might_have_observers());

if (context_)

context_->RemoveLiveRegistration(registration_id_);

@@ -73,7 +73,7 @@ void ServiceWorkerRegistration::NotifyUpdateFound() {

}

ServiceWorkerRegistrationInfo ServiceWorkerRegistration::GetInfo() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

return ServiceWorkerRegistrationInfo(

pattern(),

registration_id_,