Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1005673002: Make UI or API driven extension options navigations refocus any existing options page. (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make UI or API driven extension options navigations refocus any existing options page. This is already the way that the options pages embedded in chrome://extensions work. Options pages not embedded (those declared via "options_page" or with {"open_in_tab": true} in "options_ui") currently always open in a new tab - now it will refocus instead. This will affect any caller of ExtensionTabUtil::OpenOptionsPage - called from UI like the toolbar button's context menu, and from the chrome.browser.openOptionsPage API call. An important side-effect of all of this is that the old behavior is buggy when a devtools window is focused (see crash report), and this fixes it. This was impossible to trigger until we added the chrome.browser.openOptionsPage() - now quite likely that a devtools window is focused. BUG=430054, 463341 R=rockot@chromium.org Committed: https://crrev.com/4427c25096a309a9aef54b563086c1dccc2ebece Cr-Commit-Position: refs/heads/master@{#320426}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -31 lines) Patch
M chrome/browser/extensions/extension_tab_util.cc View 1 1 chunk +14 lines, -23 lines 0 comments Download
M chrome/test/data/extensions/api_test/runtime/open_options_page/manifest.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/runtime/open_options_page/test.js View 1 1 chunk +57 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
not at google - send to devlin
5 years, 9 months ago (2015-03-12 21:42:05 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-12 22:52:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005673002/20001
5 years, 9 months ago (2015-03-12 22:56:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-13 01:56:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 01:57:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4427c25096a309a9aef54b563086c1dccc2ebece
Cr-Commit-Position: refs/heads/master@{#320426}

Powered by Google App Engine
This is Rietveld 408576698