Issue 1005633002: Factor ScrollCurve out of Scrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1005633002: Factor ScrollCurve out of Scrollable (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Factor ScrollCurve out of Scrollable Intead of hard-coding the notion of bounded scrolling into Scrollable, this CL factors out a ScrollCurve class that applies the bounds. In the future, we'll refine this mechanism to implement overflow scrolling. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9302402882c27da3320b3c1f00ee83e91f08cd8e

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -20 lines)			Patch
M	sky/examples/stocks-fn/stocklist.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/stocks-fn/stocksapp.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/framework/animation/scroll_curve.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	sky/framework/components/fixed_height_scrollable.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	sky/framework/components/scrollable.dart	View	2 chunks	+4 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-12 17:36:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9302402882c27da3320b3c1f00ee83e91f08cd8e (presubmit successful).