Redirect HTML resource bytes directly to parser thread (Blink side CL)

public/platform/WebURLLoader.h

 /*
  * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef WebURLLoader_h
 #define WebURLLoader_h
 
 #include "WebCommon.h"
 #include "WebURLRequest.h"
 
 namespace blink {
 
 class WebData;
+class WebThreadedDataReceiver;
 class WebURLLoaderClient;
 class WebURLResponse;
 struct WebURLError;
 
 class WebURLLoader {
 public:
     // The WebURLLoader may be deleted in a call to its client.
     virtual ~WebURLLoader() {}
 
     // Load the request synchronously, returning results directly to the
@@ skipping 12 matching lines @@
     // the client.
     virtual void cancel() = 0;
 
     // Suspends/resumes an asynchronous load.
     virtual void setDefersLoading(bool) = 0;
 
     // Notifies the loader that the priority of a WebURLRequest has changed from
     // its previous value. For example, a preload request starts with low
     // priority, but may increase when the resource is needed for rendering.
     virtual void didChangePriority(WebURLRequest::Priority newPriority) { }
+
+    // Try to attach the given data receiver which from this point will receive data
+    // on its thread, rather than the WebURLLoaderClient. If successful, ownership

[darin (slow to review), 2014/03/19 03:51:07]

you should probably indicate what thread the WebThreadedDataReceiver will be
deleted on.

[darin (slow to review), 2014/03/19 03:51:07]

"on its thread" -> might be nice to spell out that you mean the WebThread
returned from WebThreadedDataReceiver::backgroundThread.

Also, nit: why didn't you just pass the WebThread as a parameter to
attachThreadedDataReceiver? The WebThread returned from WebThreadedDataReceiver
probably needs to be stable, so it doesn't make much sense for it to be a
dynamic property (i.e., virtual function).

[oystein (OOO til 10th of July), 2014/03/21 19:26:38]

Done.
The WebThread being a property of the WebThreadedDataReceiver made sense so it
could be used for validation on the receiving side too (i.e. the assert in
ParserDataReceiver::acceptData), and it seemed nicer to only define it in one
location (i.e. backgroundThread()).  If it would make the API clearer I could
move that up to ParserDataReceiver itself though, and also pass it along as an
explicit parameter to attachThreadedDataReceiver().

+    // of the data receiver is assumed by the WebURLLoader.
+    virtual bool attachThreadedDataReceiver(WebThreadedDataReceiver*) { return false; }
 };
 
 } // namespace blink
 
 #endif