Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: Source/core/html/parser/HTMLDocumentParser.cpp

Issue 100563004: Redirect HTML resource bytes directly to parser thread (Blink side CL) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@parserthread_decodermove
Patch Set: Leak fix Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "core/dom/Element.h" 31 #include "core/dom/Element.h"
32 #include "core/frame/LocalFrame.h" 32 #include "core/frame/LocalFrame.h"
33 #include "core/html/HTMLDocument.h" 33 #include "core/html/HTMLDocument.h"
34 #include "core/html/parser/AtomicHTMLToken.h" 34 #include "core/html/parser/AtomicHTMLToken.h"
35 #include "core/html/parser/BackgroundHTMLParser.h" 35 #include "core/html/parser/BackgroundHTMLParser.h"
36 #include "core/html/parser/HTMLParserScheduler.h" 36 #include "core/html/parser/HTMLParserScheduler.h"
37 #include "core/html/parser/HTMLParserThread.h" 37 #include "core/html/parser/HTMLParserThread.h"
38 #include "core/html/parser/HTMLScriptRunner.h" 38 #include "core/html/parser/HTMLScriptRunner.h"
39 #include "core/html/parser/HTMLTreeBuilder.h" 39 #include "core/html/parser/HTMLTreeBuilder.h"
40 #include "core/inspector/InspectorInstrumentation.h" 40 #include "core/inspector/InspectorInstrumentation.h"
41 #include "core/loader/DocumentLoader.h"
41 #include "platform/SharedBuffer.h" 42 #include "platform/SharedBuffer.h"
42 #include "platform/TraceEvent.h" 43 #include "platform/TraceEvent.h"
44 #include "public/platform/WebThreadedDataReceiver.h"
43 #include "wtf/Functional.h" 45 #include "wtf/Functional.h"
44 46
45 namespace WebCore { 47 namespace WebCore {
46 48
47 using namespace HTMLNames; 49 using namespace HTMLNames;
48 50
49 // This is a direct transcription of step 4 from: 51 // This is a direct transcription of step 4 from:
50 // http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#frag ment-case 52 // http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#frag ment-case
51 static HTMLTokenizer::State tokenizerStateForContextElement(Element* contextElem ent, bool reportErrors, const HTMLParserOptions& options) 53 static HTMLTokenizer::State tokenizerStateForContextElement(Element* contextElem ent, bool reportErrors, const HTMLParserOptions& options)
52 { 54 {
(...skipping 11 matching lines...) Expand all
64 || (contextTag.matches(noscriptTag) && options.scriptEnabled) 66 || (contextTag.matches(noscriptTag) && options.scriptEnabled)
65 || contextTag.matches(noframesTag)) 67 || contextTag.matches(noframesTag))
66 return reportErrors ? HTMLTokenizer::RAWTEXTState : HTMLTokenizer::PLAIN TEXTState; 68 return reportErrors ? HTMLTokenizer::RAWTEXTState : HTMLTokenizer::PLAIN TEXTState;
67 if (contextTag.matches(scriptTag)) 69 if (contextTag.matches(scriptTag))
68 return reportErrors ? HTMLTokenizer::ScriptDataState : HTMLTokenizer::PL AINTEXTState; 70 return reportErrors ? HTMLTokenizer::ScriptDataState : HTMLTokenizer::PL AINTEXTState;
69 if (contextTag.matches(plaintextTag)) 71 if (contextTag.matches(plaintextTag))
70 return HTMLTokenizer::PLAINTEXTState; 72 return HTMLTokenizer::PLAINTEXTState;
71 return HTMLTokenizer::DataState; 73 return HTMLTokenizer::DataState;
72 } 74 }
73 75
76 class ParserDataReceiver : public blink::WebThreadedDataReceiver {
77 public:
78 explicit ParserDataReceiver(WeakPtr<BackgroundHTMLParser> backgroundParser)
79 : m_backgroundParser(backgroundParser)
80 {
81 }
82
83 // WebThreadedDataReceiver
84 virtual void acceptData(const char* data, int dataLength) OVERRIDE FINAL
85 {
86 ASSERT(backgroundThread()->isCurrentThread());
87 if (m_backgroundParser.get())
88 m_backgroundParser.get()->appendRawBytesFromParserThread(data, dataL ength);
89 }
90
91 virtual blink::WebThread* backgroundThread() OVERRIDE FINAL
92 {
93 return &HTMLParserThread::shared()->platformThread();
94 }
95
96 private:
97 WeakPtr<BackgroundHTMLParser> m_backgroundParser;
98 };
99
74 HTMLDocumentParser::HTMLDocumentParser(HTMLDocument* document, bool reportErrors ) 100 HTMLDocumentParser::HTMLDocumentParser(HTMLDocument* document, bool reportErrors )
75 : ScriptableDocumentParser(document) 101 : ScriptableDocumentParser(document)
76 , m_options(document) 102 , m_options(document)
77 , m_token(m_options.useThreading ? nullptr : adoptPtr(new HTMLToken)) 103 , m_token(m_options.useThreading ? nullptr : adoptPtr(new HTMLToken))
78 , m_tokenizer(m_options.useThreading ? nullptr : HTMLTokenizer::create(m_opt ions)) 104 , m_tokenizer(m_options.useThreading ? nullptr : HTMLTokenizer::create(m_opt ions))
79 , m_scriptRunner(HTMLScriptRunner::create(document, this)) 105 , m_scriptRunner(HTMLScriptRunner::create(document, this))
80 , m_treeBuilder(HTMLTreeBuilder::create(this, document, parserContentPolicy( ), reportErrors, m_options)) 106 , m_treeBuilder(HTMLTreeBuilder::create(this, document, parserContentPolicy( ), reportErrors, m_options))
81 , m_parserScheduler(HTMLParserScheduler::create(this)) 107 , m_parserScheduler(HTMLParserScheduler::create(this))
82 , m_xssAuditorDelegate(document) 108 , m_xssAuditorDelegate(document)
83 , m_weakFactory(this) 109 , m_weakFactory(this)
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 void HTMLDocumentParser::startBackgroundParser() 686 void HTMLDocumentParser::startBackgroundParser()
661 { 687 {
662 ASSERT(!isStopped()); 688 ASSERT(!isStopped());
663 ASSERT(shouldUseThreading()); 689 ASSERT(shouldUseThreading());
664 ASSERT(!m_haveBackgroundParser); 690 ASSERT(!m_haveBackgroundParser);
665 m_haveBackgroundParser = true; 691 m_haveBackgroundParser = true;
666 692
667 RefPtr<WeakReference<BackgroundHTMLParser> > reference = WeakReference<Backg roundHTMLParser>::createUnbound(); 693 RefPtr<WeakReference<BackgroundHTMLParser> > reference = WeakReference<Backg roundHTMLParser>::createUnbound();
668 m_backgroundParser = WeakPtr<BackgroundHTMLParser>(reference); 694 m_backgroundParser = WeakPtr<BackgroundHTMLParser>(reference);
669 695
696 document()->loader()->attachThreadedDataReceiver(adoptPtr(new ParserDataRece iver(m_backgroundParser)));
697
670 OwnPtr<BackgroundHTMLParser::Configuration> config = adoptPtr(new Background HTMLParser::Configuration); 698 OwnPtr<BackgroundHTMLParser::Configuration> config = adoptPtr(new Background HTMLParser::Configuration);
671 config->options = m_options; 699 config->options = m_options;
672 config->parser = m_weakFactory.createWeakPtr(); 700 config->parser = m_weakFactory.createWeakPtr();
673 config->xssAuditor = adoptPtr(new XSSAuditor); 701 config->xssAuditor = adoptPtr(new XSSAuditor);
674 config->xssAuditor->init(document(), &m_xssAuditorDelegate); 702 config->xssAuditor->init(document(), &m_xssAuditorDelegate);
675 config->preloadScanner = adoptPtr(new TokenPreloadScanner(document()->url(). copy(), document()->devicePixelRatio())); 703 config->preloadScanner = adoptPtr(new TokenPreloadScanner(document()->url(). copy(), document()->devicePixelRatio()));
676 config->decoder = takeDecoder(); 704 config->decoder = takeDecoder();
677 705
678 ASSERT(config->xssAuditor->isSafeToSendToAnotherThread()); 706 ASSERT(config->xssAuditor->isSafeToSendToAnotherThread());
679 ASSERT(config->preloadScanner->isSafeToSendToAnotherThread()); 707 ASSERT(config->preloadScanner->isSafeToSendToAnotherThread());
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 return; 997 return;
970 998
971 if (shouldUseThreading()) { 999 if (shouldUseThreading()) {
972 if (!m_haveBackgroundParser) 1000 if (!m_haveBackgroundParser)
973 startBackgroundParser(); 1001 startBackgroundParser();
974 1002
975 OwnPtr<Vector<char> > buffer = adoptPtr(new Vector<char>(length)); 1003 OwnPtr<Vector<char> > buffer = adoptPtr(new Vector<char>(length));
976 memcpy(buffer->data(), data, length); 1004 memcpy(buffer->data(), data, length);
977 TRACE_EVENT1("net", "HTMLDocumentParser::appendBytes", "size", (unsigned )length); 1005 TRACE_EVENT1("net", "HTMLDocumentParser::appendBytes", "size", (unsigned )length);
978 1006
979 HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::appendB ytes, m_backgroundParser, buffer.release())); 1007 HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::appendR awBytesFromMainThread, m_backgroundParser, buffer.release()));
980 return; 1008 return;
981 } 1009 }
982 1010
983 DecodedDataDocumentParser::appendBytes(data, length); 1011 DecodedDataDocumentParser::appendBytes(data, length);
984 } 1012 }
985 1013
986 void HTMLDocumentParser::flush() 1014 void HTMLDocumentParser::flush()
987 { 1015 {
988 // If we've got no decoder, we never received any data. 1016 // If we've got no decoder, we never received any data.
989 if (isDetached() || needsDecoder()) 1017 if (isDetached() || needsDecoder())
990 return; 1018 return;
991 1019
992 if (m_haveBackgroundParser) 1020 if (m_haveBackgroundParser)
993 HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::flush, m_backgroundParser)); 1021 HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::flush, m_backgroundParser));
994 else 1022 else
995 DecodedDataDocumentParser::flush(); 1023 DecodedDataDocumentParser::flush();
996 } 1024 }
997 1025
998 void HTMLDocumentParser::setDecoder(PassOwnPtr<TextResourceDecoder> decoder) 1026 void HTMLDocumentParser::setDecoder(PassOwnPtr<TextResourceDecoder> decoder)
999 { 1027 {
1000 ASSERT(decoder); 1028 ASSERT(decoder);
1001 DecodedDataDocumentParser::setDecoder(decoder); 1029 DecodedDataDocumentParser::setDecoder(decoder);
1002 1030
1003 if (m_haveBackgroundParser) 1031 if (m_haveBackgroundParser)
1004 HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::setDeco der, m_backgroundParser, takeDecoder())); 1032 HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::setDeco der, m_backgroundParser, takeDecoder()));
1005 } 1033 }
1006 1034
1007 } 1035 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698