Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1005603003: [views] Add checkmark throbber to card unmasking prompt (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, estade+watch_chromium.org, oshima+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[views] Add checkmark throbber to card unmasking prompt Also add a new, prettier checkmark asset. (It doesn't appear this is actually used anywhere else, so no other UIs should be affected.) BUG=none Committed: https://crrev.com/ad0deae6aeb4b4996203ff40a917e1c88dc8b447 Cr-Commit-Position: refs/heads/master@{#322252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 6 chunks +14 lines, -3 lines 0 comments Download
M ui/resources/default_100_percent/common/checkmark.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/checkmark.png View Binary file 0 comments Download

Messages

Total messages: 11 (4 generated)
Evan Stade
5 years, 9 months ago (2015-03-24 19:45:58 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-24 22:08:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005603003/1
5 years, 9 months ago (2015-03-24 22:18:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/46796)
5 years, 9 months ago (2015-03-25 03:47:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005603003/1
5 years, 9 months ago (2015-03-25 21:48:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 22:30:05 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:30:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad0deae6aeb4b4996203ff40a917e1c88dc8b447
Cr-Commit-Position: refs/heads/master@{#322252}

Powered by Google App Engine
This is Rietveld 408576698