Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1005583003: VideoCapturerSource: cleanup (Closed)

Created:
5 years, 9 months ago by mcasas
Modified:
5 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCapturerSource: cleanup VCS does not need an out of line destructor since it's a pure virtual abstract class. No need for .cc file either. Correction: it's needed in GN component build in MSVC11 compiler platforms, otherwise the dtor ~VideoCapturerSource() is not found when linking. Cleaned up unneeded media:: namespace refs. Corrected #ifdef... path. Removed two superfluous includes. BUG=440843

Patch Set 1 #

Patch Set 2 : Compile destructor _only on windows_. #

Patch Set 3 : Try again removing the .cpp file entirely, and leaving the dtor in the header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M media/base/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/base/video_capturer_source.h View 1 2 4 chunks +19 lines, -18 lines 0 comments Download
D media/base/video_capturer_source.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M media/media.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mcasas
hubbe@ PTAL scherkus@ OWNERS RS
5 years, 9 months ago (2015-03-12 17:10:51 UTC) #2
hubbe
lgtm
5 years, 9 months ago (2015-03-12 17:15:59 UTC) #3
scherkus (not reviewing)
lgtm
5 years, 9 months ago (2015-03-12 18:43:18 UTC) #4
mcasas
Guys please have another look... Some Windows bots were sad on component build, possibly GN ...
5 years, 9 months ago (2015-03-18 23:49:05 UTC) #9
hubbe
5 years, 7 months ago (2015-05-01 18:50:22 UTC) #10
On 2015/03/18 23:49:05, mcasas wrote:
> Guys please have another look...
> 
> Some Windows bots were sad on component build, possibly
> GN does not define the appropriate flag, and MSVC11 does
> not find  ~VideoCapturerSource() if it's defined on the
> header only. I hereby sadly heed to adding an 
> implementation file for Win only :'(

Just having the an implementation file for all platforms seems cleaner.

Powered by Google App Engine
This is Rietveld 408576698