Chromium Code Reviews
DescriptionVideoCapturerSource: cleanup
VCS does not need an out of line destructor since
it's a pure virtual abstract class. No need for
.cc file either.
Correction: it's needed in GN component build in
MSVC11 compiler platforms, otherwise the dtor
~VideoCapturerSource() is not found when linking.
Cleaned up unneeded media:: namespace refs.
Corrected #ifdef... path.
Removed two superfluous includes.
BUG=440843
Patch Set 1 #Patch Set 2 : Compile destructor _only on windows_. #Patch Set 3 : Try again removing the .cpp file entirely, and leaving the dtor in the header file #
Messages
Total messages: 12 (7 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||