Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: test/mjsunit/es7/object-observe.js

Issue 1005553003: Fix error message for Object.observe accept argument (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Improve error message, simplify test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/object-observe.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
1817 fun.name = 'c'; // Same, no update. 1817 fun.name = 'c'; // Same, no update.
1818 Object.deliverChangeRecords(observer.callback); 1818 Object.deliverChangeRecords(observer.callback);
1819 observer.assertCallbackRecords([ 1819 observer.assertCallbackRecords([
1820 { object: fun, type: 'update', name: 'name', oldValue: 'fun' }, 1820 { object: fun, type: 'update', name: 'name', oldValue: 'fun' },
1821 { object: fun, type: 'reconfigure', name: 'name'}, 1821 { object: fun, type: 'reconfigure', name: 'name'},
1822 { object: fun, type: 'update', name: 'name', oldValue: 'a' }, 1822 { object: fun, type: 'update', name: 'name', oldValue: 'a' },
1823 { object: fun, type: 'delete', name: 'name', oldValue: 'b' }, 1823 { object: fun, type: 'delete', name: 'name', oldValue: 'b' },
1824 { object: fun, type: 'add', name: 'name' }, 1824 { object: fun, type: 'add', name: 'name' },
1825 ]); 1825 ]);
1826 })(); 1826 })();
1827
1828
1829 (function TestObserveInvalidAcceptMessage() {
1830 var ex;
1831 try {
1832 Object.observe({}, function(){}, "not an object");
1833 } catch (e) {
1834 ex = e;
1835 }
1836 assertInstanceof(ex, TypeError);
1837 assertEquals("Third argument to Object.observe must be an array of strings.",
1838 ex.message);
1839 })()
OLDNEW
« no previous file with comments | « src/object-observe.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698