Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/messages.js

Issue 1005553003: Fix error message for Object.observe accept argument (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Improve error message, simplify test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/object-observe.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // ------------------------------------------------------------------- 5 // -------------------------------------------------------------------
6 6
7 var kMessages = { 7 var kMessages = {
8 // Error 8 // Error
9 cyclic_proto: ["Cyclic __proto__ value"], 9 cyclic_proto: ["Cyclic __proto__ value"],
10 code_gen_from_strings: ["%0"], 10 code_gen_from_strings: ["%0"],
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 handler_returned_undefined: ["Proxy handler ", "%0", " returned undefined f rom '", "%1", "' trap"], 74 handler_returned_undefined: ["Proxy handler ", "%0", " returned undefined f rom '", "%1", "' trap"],
75 proxy_prop_not_configurable: ["Proxy handler ", "%0", " returned non-configu rable descriptor for property '", "%2", "' from '", "%1", "' trap"], 75 proxy_prop_not_configurable: ["Proxy handler ", "%0", " returned non-configu rable descriptor for property '", "%2", "' from '", "%1", "' trap"],
76 proxy_non_object_prop_names: ["Trap '", "%1", "' returned non-object ", "%0" ], 76 proxy_non_object_prop_names: ["Trap '", "%1", "' returned non-object ", "%0" ],
77 proxy_repeated_prop_name: ["Trap '", "%1", "' returned repeated property name '", "%2", "'"], 77 proxy_repeated_prop_name: ["Trap '", "%1", "' returned repeated property name '", "%2", "'"],
78 invalid_weakmap_key: ["Invalid value used as weak map key"], 78 invalid_weakmap_key: ["Invalid value used as weak map key"],
79 invalid_weakset_value: ["Invalid value used in weak set"], 79 invalid_weakset_value: ["Invalid value used in weak set"],
80 not_date_object: ["this is not a Date object."], 80 not_date_object: ["this is not a Date object."],
81 observe_non_object: ["Object.", "%0", " cannot ", "%0", " non-objec t"], 81 observe_non_object: ["Object.", "%0", " cannot ", "%0", " non-objec t"],
82 observe_non_function: ["Object.", "%0", " cannot deliver to non-funct ion"], 82 observe_non_function: ["Object.", "%0", " cannot deliver to non-funct ion"],
83 observe_callback_frozen: ["Object.observe cannot deliver to a frozen fun ction object"], 83 observe_callback_frozen: ["Object.observe cannot deliver to a frozen fun ction object"],
84 observe_invalid_accept: ["Object.observe accept must be an array of str ings."], 84 observe_invalid_accept: ["Third argument to Object.observe must be an a rray of strings."],
85 observe_type_non_string: ["Invalid changeRecord with non-string 'type' p roperty"], 85 observe_type_non_string: ["Invalid changeRecord with non-string 'type' p roperty"],
86 observe_perform_non_string: ["Invalid non-string changeType"], 86 observe_perform_non_string: ["Invalid non-string changeType"],
87 observe_perform_non_function: ["Cannot perform non-function"], 87 observe_perform_non_function: ["Cannot perform non-function"],
88 observe_notify_non_notifier: ["notify called on non-notifier object"], 88 observe_notify_non_notifier: ["notify called on non-notifier object"],
89 observe_global_proxy: ["%0", " cannot be called on the global proxy o bject"], 89 observe_global_proxy: ["%0", " cannot be called on the global proxy o bject"],
90 not_typed_array: ["this is not a typed array."], 90 not_typed_array: ["this is not a typed array."],
91 invalid_argument: ["invalid_argument"], 91 invalid_argument: ["invalid_argument"],
92 data_view_not_array_buffer: ["First argument to DataView constructor must b e an ArrayBuffer"], 92 data_view_not_array_buffer: ["First argument to DataView constructor must b e an ArrayBuffer"],
93 constructor_not_function: ["Constructor ", "%0", " requires 'new'"], 93 constructor_not_function: ["Constructor ", "%0", " requires 'new'"],
94 not_a_symbol: ["%0", " is not a symbol"], 94 not_a_symbol: ["%0", " is not a symbol"],
(...skipping 1228 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 function SetUpStackOverflowBoilerplate() { 1323 function SetUpStackOverflowBoilerplate() {
1324 var boilerplate = MakeRangeError('stack_overflow', []); 1324 var boilerplate = MakeRangeError('stack_overflow', []);
1325 1325
1326 %DefineAccessorPropertyUnchecked( 1326 %DefineAccessorPropertyUnchecked(
1327 boilerplate, 'stack', StackTraceGetter, StackTraceSetter, DONT_ENUM); 1327 boilerplate, 'stack', StackTraceGetter, StackTraceSetter, DONT_ENUM);
1328 1328
1329 return boilerplate; 1329 return boilerplate;
1330 } 1330 }
1331 1331
1332 var kStackOverflowBoilerplate = SetUpStackOverflowBoilerplate(); 1332 var kStackOverflowBoilerplate = SetUpStackOverflowBoilerplate();
OLDNEW
« no previous file with comments | « no previous file | src/object-observe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698