Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1817 fun.name = 'c'; // Same, no update. | 1817 fun.name = 'c'; // Same, no update. |
| 1818 Object.deliverChangeRecords(observer.callback); | 1818 Object.deliverChangeRecords(observer.callback); |
| 1819 observer.assertCallbackRecords([ | 1819 observer.assertCallbackRecords([ |
| 1820 { object: fun, type: 'update', name: 'name', oldValue: 'fun' }, | 1820 { object: fun, type: 'update', name: 'name', oldValue: 'fun' }, |
| 1821 { object: fun, type: 'reconfigure', name: 'name'}, | 1821 { object: fun, type: 'reconfigure', name: 'name'}, |
| 1822 { object: fun, type: 'update', name: 'name', oldValue: 'a' }, | 1822 { object: fun, type: 'update', name: 'name', oldValue: 'a' }, |
| 1823 { object: fun, type: 'delete', name: 'name', oldValue: 'b' }, | 1823 { object: fun, type: 'delete', name: 'name', oldValue: 'b' }, |
| 1824 { object: fun, type: 'add', name: 'name' }, | 1824 { object: fun, type: 'add', name: 'name' }, |
| 1825 ]); | 1825 ]); |
| 1826 })(); | 1826 })(); |
| 1827 | |
| 1828 | |
| 1829 (function TestObserveInvalidAcceptMessage() { | |
| 1830 try { | |
|
arv (Not doing code reviews)
2015/03/12 17:56:25
Here is another way to write this:
var ex;
try {
| |
| 1831 Object.observe({}, function(){}, "not an object"); | |
| 1832 } catch (e) { | |
| 1833 assertInstanceof(e, TypeError); | |
| 1834 assertEquals("Object.observe accept must be an array of strings.", | |
| 1835 e.message); | |
|
caitp (gmail)
2015/03/12 18:00:17
kind of a nit, but the observe_invalid_accept mess
| |
| 1836 return; | |
| 1837 } | |
| 1838 fail("TypeError", "no exception"); | |
| 1839 })() | |
| OLD | NEW |