Fix error message for Object.observe accept argument

Fix error message for Object.observe accept argument

BUG=chromium:464695
LOG=n

Committed: https://crrev.com/0c305e0b1be7ab2fb00a8d10572ec1222e4c0c35
Cr-Commit-Position: refs/heads/master@{#27171}

[adamk, 2015-03-12 17:53:07]

Patchset #1 (id:1) has been deleted

[adamk, 2015-03-12 17:53:21]

adamk@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-03-12 17:56:25]

LGTM

https://codereview.chromium.org/1005553003/diff/20001/test/mjsunit/es7/object...
File test/mjsunit/es7/object-observe.js (right):

https://codereview.chromium.org/1005553003/diff/20001/test/mjsunit/es7/object...
test/mjsunit/es7/object-observe.js:1830: try {
Here is another way to write this:

var ex;
try {
  ...
} catch (e) {
  ex = e;
}
assertInstanceof(ex, TypeError);
assertEquals("Object.observe accept must be an array of strings.",
             ex.message);

Then you don't need the return and fail at the end.

[caitp (gmail), 2015-03-12 18:00:16]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2015-03-12 18:00:17]

https://codereview.chromium.org/1005553003/diff/20001/test/mjsunit/es7/object...
File test/mjsunit/es7/object-observe.js (right):

https://codereview.chromium.org/1005553003/diff/20001/test/mjsunit/es7/object...
test/mjsunit/es7/object-observe.js:1835: e.message);
kind of a nit, but the observe_invalid_accept message reads really weirdly to
me. It would be good to make it clear in the message that "accept" is talking
about a parameter name

[adamk, 2015-03-12 18:06:59]

Thanks for both pieces of feedback, I've improved the error message and made the
test more sane (that's what I get for coding before coffee).

[adamk, 2015-03-12 18:07:05]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-03-12 18:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1005553003/#ps40001
(title: "Improve error message, simplify test")

[commit-bot: I haz the power, 2015-03-12 18:07:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1005553003/40001

[commit-bot: I haz the power, 2015-03-12 19:04:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-12 19:04:45]

Patchset 2 (id:??) landed as
https://crrev.com/0c305e0b1be7ab2fb00a8d10572ec1222e4c0c35
Cr-Commit-Position: refs/heads/master@{#27171}