Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/pending_extension_manager.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/pending_extension_info.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/pending_extension_manager.cc
diff --git a/extensions/browser/pending_extension_manager.cc b/extensions/browser/pending_extension_manager.cc
index d16b92b9dfb7856109a408de3eee8becce1f9414..ae74e41c60119694aec05340c61fc1f057c1e5ca 100644
--- a/extensions/browser/pending_extension_manager.cc
+++ b/extensions/browser/pending_extension_manager.cc
@@ -22,7 +22,7 @@ bool AlwaysInstall(const extensions::Extension* extension) {
return true;
}
-std::string GetVersionString(const Version& version) {
+std::string GetVersionString(const base::Version& version) {
return version.IsValid() ? version.GetString() : "invalid";
}
@@ -109,7 +109,7 @@ bool PendingExtensionManager::AddFromSync(
const Manifest::Location kSyncLocation = Manifest::INTERNAL;
const bool kMarkAcknowledged = false;
- return AddExtensionImpl(id, update_url, Version(), should_allow_install,
+ return AddExtensionImpl(id, update_url, base::Version(), should_allow_install,
kIsFromSync, install_silently, kSyncLocation,
Extension::NO_FLAGS, kMarkAcknowledged);
}
@@ -131,7 +131,7 @@ bool PendingExtensionManager::AddFromExtensionImport(
const Manifest::Location kManifestLocation = Manifest::INTERNAL;
const bool kMarkAcknowledged = false;
- return AddExtensionImpl(id, update_url, Version(), should_allow_install,
+ return AddExtensionImpl(id, update_url, base::Version(), should_allow_install,
kIsFromSync, kInstallSilently, kManifestLocation,
Extension::NO_FLAGS, kMarkAcknowledged);
}
@@ -164,7 +164,7 @@ bool PendingExtensionManager::AddFromExternalUpdateUrl(
}
}
- return AddExtensionImpl(id, update_url, Version(), &AlwaysInstall,
+ return AddExtensionImpl(id, update_url, base::Version(), &AlwaysInstall,
kIsFromSync, kInstallSilently,
location, creation_flags, mark_acknowledged);
}
@@ -173,7 +173,7 @@ bool PendingExtensionManager::AddFromExternalUpdateUrl(
bool PendingExtensionManager::AddFromExternalFile(
const std::string& id,
Manifest::Location install_source,
- const Version& version,
+ const base::Version& version,
int creation_flags,
bool mark_acknowledged) {
// TODO(skerner): AddFromSync() checks to see if the extension is
@@ -218,7 +218,7 @@ void PendingExtensionManager::GetPendingIdsForUpdateCheck(
bool PendingExtensionManager::AddExtensionImpl(
const std::string& id,
const GURL& update_url,
- const Version& version,
+ const base::Version& version,
PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install,
bool is_from_sync,
bool install_silently,
« no previous file with comments | « extensions/browser/pending_extension_info.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698