chrome/installer/util/google_update_settings_unittest.cc - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_settings_unittest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/google_update_settings_unittest.cc

diff --git a/chrome/installer/util/google_update_settings_unittest.cc b/chrome/installer/util/google_update_settings_unittest.cc

index 85a056ff891a426dad853efaa89233d8cb88d59b..06e8b8bd3d45d611f38a0c47935a98e14b996d71 100644

--- a/chrome/installer/util/google_update_settings_unittest.cc

+++ b/chrome/installer/util/google_update_settings_unittest.cc

@@ -455,7 +455,7 @@ TEST_F(GoogleUpdateSettingsTest, SetEULAConsent) {

// Chrome is installed.

machine_state.AddChrome(system_level, multi_install,

- new Version(chrome::kChromeVersion));

+ new base::Version(chrome::kChromeVersion));

RegKey key;

DWORD value;

@@ -749,7 +749,7 @@ TEST_P(GetGoogleUpdateVersion, TestEmptyValue) {

TEST_P(GetGoogleUpdateVersion, TestRealValue) {

RegKey(root_key_, google_update::kRegPathGoogleUpdate, KEY_SET_VALUE)

.WriteValue(google_update::kRegGoogleUpdateVersion, kDummyVersion);

- Version expected(UTF16ToUTF8(kDummyVersion));

+ base::Version expected(UTF16ToUTF8(kDummyVersion));

EXPECT_TRUE(expected.Equals(

GoogleUpdateSettings::GetGoogleUpdateVersion(system_install_)));

// Make sure that there's no value in the other level (user or system).

« no previous file with comments | « chrome/installer/util/google_update_settings.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »