Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5086)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 6e17a991a51bbb2f60ea9d8aaf092587420659ce..f8e4c3c5d63b3cd5339333e2a8e7374d14891823 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -154,8 +154,8 @@ void ProcessOnOsUpgradeWorkItems(
const installer::Product& product) {
scoped_ptr<WorkItemList> work_item_list(
WorkItem::CreateNoRollbackWorkItemList());
- AddOsUpgradeWorkItems(installer_state, base::FilePath(), Version(), product,
- work_item_list.get());
+ AddOsUpgradeWorkItems(installer_state, base::FilePath(), base::Version(),
+ product, work_item_list.get());
if (!work_item_list->Do())
LOG(ERROR) << "Failed to remove on-os-upgrade command.";
}
@@ -521,8 +521,9 @@ DeleteResult DeleteChromeDirectoriesIfEmpty(
return result;
}
-DeleteResult DeleteAppHostFilesAndFolders(const InstallerState& installer_state,
- const Version& installed_version) {
+DeleteResult DeleteAppHostFilesAndFolders(
+ const InstallerState& installer_state,
+ const base::Version& installed_version) {
const base::FilePath& target_path = installer_state.target_path();
if (target_path.empty()) {
LOG(ERROR) << "DeleteAppHostFilesAndFolders: no installation destination "
@@ -916,8 +917,8 @@ const wchar_t kChromeExtProgId[] = L"ChromiumExt";
bool ProcessDelegateExecuteWorkItems(const InstallerState& installer_state,
const Product& product) {
scoped_ptr<WorkItemList> item_list(WorkItem::CreateNoRollbackWorkItemList());
- AddDelegateExecuteWorkItems(installer_state, base::FilePath(), Version(),
- product, item_list.get());
+ AddDelegateExecuteWorkItems(installer_state, base::FilePath(),
+ base::Version(), product, item_list.get());
return item_list->Do();
}
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698