chrome/installer/setup/install.h - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.h

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.h

diff --git a/chrome/installer/setup/install.h b/chrome/installer/setup/install.h

index a700b3c8be7200ee71af62dfe2f624d1ed2e6450..3c8093583e7bb476fd9cef2b468b4ca6c1cde6b6 100644

--- a/chrome/installer/setup/install.h

+++ b/chrome/installer/setup/install.h

@@ -58,7 +58,7 @@ void EscapeXmlAttributeValueInSingleQuotes(base::string16* att_value);

// |src_path|\VisualElements exists.

// Returns true unless the manifest is supposed to be created, but fails to be.

bool CreateVisualElementsManifest(const base::FilePath& src_path,

- const Version& version);

+ const base::Version& version);

// Overwrites shortcuts (desktop, quick launch, and start menu) if they are

// present on the system.

@@ -114,7 +114,7 @@ InstallStatus InstallOrUpdateProduct(

const base::FilePath& src_path,

const base::FilePath& prefs_path,

const installer::MasterPreferences& prefs,

- const Version& new_version);

+ const base::Version& new_version);

// Performs installation-related tasks following an OS upgrade.

// |chrome| The installed product (must be a browser).

« no previous file with comments | « chrome/common/service_process_util_mac.mm ('k') | chrome/installer/setup/install.cc » ('j') | no next file with comments »