chrome/common/service_process_util_mac.mm - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_mac.mm

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/service_process_util_mac.mm

diff --git a/chrome/common/service_process_util_mac.mm b/chrome/common/service_process_util_mac.mm

index d02362737a5feaf9732a484c42ebf8f4311433aa..8dd7525bfad4de7ecf059044befa31db80898128 100644

--- a/chrome/common/service_process_util_mac.mm

+++ b/chrome/common/service_process_util_mac.mm

@@ -203,7 +203,7 @@ bool CheckServiceProcessReady() {

if (!GetServiceProcessData(&version, &pid)) {

return false;

}

- Version service_version(version);

+ base::Version service_version(version);

bool ready = true;

if (!service_version.IsValid()) {

ready = false;

@@ -216,7 +216,7 @@ bool CheckServiceProcessReady() {

ready = true;

}

else {

- Version running_version(version_info.Version());

+ base::Version running_version(version_info.Version());

if (!running_version.IsValid()) {

// Our own version is invalid. This is an error case. Pretend that we

// are out of date.

« no previous file with comments | « chrome/common/service_process_util.cc ('k') | chrome/installer/setup/install.h » ('j') | no next file with comments »