Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: chrome/browser/chromeos/extensions/external_cache.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/external_cache.cc
diff --git a/chrome/browser/chromeos/extensions/external_cache.cc b/chrome/browser/chromeos/extensions/external_cache.cc
index 58189161c87cbca33893cad69044d362ef644878..75cf2c46a6c3062c3caf28c5a6730944ed3e829c 100644
--- a/chrome/browser/chromeos/extensions/external_cache.cc
+++ b/chrome/browser/chromeos/extensions/external_cache.cc
@@ -341,7 +341,7 @@ void ExternalCache::BackendCheckCacheContentsInternal(
id.clear();
}
- if (!Version(version).IsValid()) {
+ if (!base::Version(version).IsValid()) {
LOG(ERROR) << "Bad extension version in ExternalCache: " << version;
version.clear();
}
@@ -376,8 +376,8 @@ void ExternalCache::BackendCheckCacheContentsInternal(
&prev_version_string) &&
entry->GetString(extensions::ExternalProviderImpl::kExternalCrx,
&prev_crx)) {
- Version prev_version(prev_version_string);
- Version curr_version(version);
+ base::Version prev_version(prev_version_string);
+ base::Version curr_version(version);
DCHECK(prev_version.IsValid());
DCHECK(curr_version.IsValid());
if (prev_version.CompareTo(curr_version) <= 0) {
@@ -472,7 +472,7 @@ void ExternalCache::BackendInstallCacheEntry(
const std::string& id,
const base::FilePath& path,
const std::string& version) {
- Version version_validator(version);
+ base::Version version_validator(version);
if (!version_validator.IsValid()) {
LOG(ERROR) << "ExternalCache downloaded extension " << id << " but got bad "
<< "version: " << version;
« no previous file with comments | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/browser/chromeos/login/existing_user_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698