Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/browser/extensions/crx_installer.h

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 Manifest::Location install_source() const { 118 Manifest::Location install_source() const {
119 return install_source_; 119 return install_source_;
120 } 120 }
121 void set_install_source(Manifest::Location source) { 121 void set_install_source(Manifest::Location source) {
122 install_source_ = source; 122 install_source_ = source;
123 } 123 }
124 124
125 const std::string& expected_id() const { return expected_id_; } 125 const std::string& expected_id() const { return expected_id_; }
126 void set_expected_id(const std::string& val) { expected_id_ = val; } 126 void set_expected_id(const std::string& val) { expected_id_ = val; }
127 127
128 void set_expected_version(const Version& val) { 128 void set_expected_version(const base::Version& val) {
129 expected_version_.reset(new Version(val)); 129 expected_version_.reset(new base::Version(val));
130 expected_version_strict_checking_ = true; 130 expected_version_strict_checking_ = true;
131 } 131 }
132 132
133 bool delete_source() const { return delete_source_; } 133 bool delete_source() const { return delete_source_; }
134 void set_delete_source(bool val) { delete_source_ = val; } 134 void set_delete_source(bool val) { delete_source_ = val; }
135 135
136 bool allow_silent_install() const { return allow_silent_install_; } 136 bool allow_silent_install() const { return allow_silent_install_; }
137 void set_allow_silent_install(bool val) { allow_silent_install_ = val; } 137 void set_allow_silent_install(bool val) { allow_silent_install_ = val; }
138 138
139 bool is_gallery_install() const { 139 bool is_gallery_install() const {
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 scoped_ptr<Manifest> expected_manifest_; 290 scoped_ptr<Manifest> expected_manifest_;
291 291
292 // The level of checking when comparing the actual manifest against 292 // The level of checking when comparing the actual manifest against
293 // the |expected_manifest_|. 293 // the |expected_manifest_|.
294 WebstoreInstaller::ManifestCheckLevel expected_manifest_check_level_; 294 WebstoreInstaller::ManifestCheckLevel expected_manifest_check_level_;
295 295
296 // If non-NULL, contains the expected version of the extension we're 296 // If non-NULL, contains the expected version of the extension we're
297 // installing. Important for external sources, where claiming the wrong 297 // installing. Important for external sources, where claiming the wrong
298 // version could cause unnecessary unpacking of an extension at every 298 // version could cause unnecessary unpacking of an extension at every
299 // restart. 299 // restart.
300 scoped_ptr<Version> expected_version_; 300 scoped_ptr<base::Version> expected_version_;
301 301
302 // If true, the actual version should be same with the |expected_version_|, 302 // If true, the actual version should be same with the |expected_version_|,
303 // Otherwise the actual version should be equal to or newer than 303 // Otherwise the actual version should be equal to or newer than
304 // the |expected_version_|. 304 // the |expected_version_|.
305 bool expected_version_strict_checking_; 305 bool expected_version_strict_checking_;
306 306
307 // Whether manual extension installation is enabled. We can't just check this 307 // Whether manual extension installation is enabled. We can't just check this
308 // before trying to install because themes are special-cased to always be 308 // before trying to install because themes are special-cased to always be
309 // allowed. 309 // allowed.
310 bool extensions_enabled_; 310 bool extensions_enabled_;
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 406
407 // Gives access to common methods and data of an extension installer. 407 // Gives access to common methods and data of an extension installer.
408 ExtensionInstaller installer_; 408 ExtensionInstaller installer_;
409 409
410 DISALLOW_COPY_AND_ASSIGN(CrxInstaller); 410 DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
411 }; 411 };
412 412
413 } // namespace extensions 413 } // namespace extensions
414 414
415 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 415 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698