Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: base/version_unittest.cc

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: someday it will work Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/version.h ('k') | chrome/app/chrome_breakpad_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 using base::Version;
10
9 namespace { 11 namespace {
10 12
11 TEST(VersionTest, DefaultConstructor) { 13 TEST(VersionTest, DefaultConstructor) {
12 Version v; 14 Version v;
13 EXPECT_FALSE(v.IsValid()); 15 EXPECT_FALSE(v.IsValid());
14 } 16 }
15 17
16 TEST(VersionTest, ValueSemantics) { 18 TEST(VersionTest, ValueSemantics) {
17 Version v1("1.2.3.4"); 19 Version v1("1.2.3.4");
18 EXPECT_TRUE(v1.IsValid()); 20 EXPECT_TRUE(v1.IsValid());
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 {"*", false}, 134 {"*", false},
133 {"*.2", false}, 135 {"*.2", false},
134 }; 136 };
135 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) { 137 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) {
136 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version), 138 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version),
137 cases[i].expected) << cases[i].version << "?" << cases[i].expected; 139 cases[i].expected) << cases[i].version << "?" << cases[i].expected;
138 } 140 }
139 } 141 }
140 142
141 } // namespace 143 } // namespace
OLDNEW
« no previous file with comments | « base/version.h ('k') | chrome/app/chrome_breakpad_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698