base/version.h - Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/version.h

Issue 100543005: Update all users of base::Version to explicitly specify the namespace, and clean up the header. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: someday it will work Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_VERSION_H_	5 #ifndef BASE_VERSION_H_

6 #define BASE_VERSION_H_	6 #define BASE_VERSION_H_

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 const std::string GetString() const;	58 const std::string GetString() const;

59	59

60 const std::vector<uint16>& components() const { return components_; }	60 const std::vector<uint16>& components() const { return components_; }

61	61

62 private:	62 private:

63 std::vector<uint16> components_;	63 std::vector<uint16> components_;

64 };	64 };

65	65

66 } // namespace base	66 } // namespace base

67	67

68 // TODO(xhwang) remove this when all users are updated to explicitly use the

69 // namespace

70 using base::Version;

71

72 #endif // BASE_VERSION_H_	68 #endif // BASE_VERSION_H_

OLD	NEW

« no previous file with comments | « no previous file | base/version_unittest.cc » ('j') | no next file with comments »